From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lucas Tanure <tanure@linux.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>
Cc: Nick <nick@khadas.com>, Artem <art@khadas.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7
Date: Wed, 21 Jun 2023 15:53:04 +0200 [thread overview]
Message-ID: <20f25e98-d02e-f914-c4e7-72bb9ddb1ae5@linaro.org> (raw)
In-Reply-To: <20230621133215.109254-3-tanure@linux.com>
On 21/06/2023 15:32, Lucas Tanure wrote:
> Amlogic T7 SoCs uses the same UART controller as S4 SoCs and G12A.
> There is no need for an extra compatible line in the driver, but
> add T7 compatible line for documentation.
>
> Signed-off-by: Lucas Tanure <tanure@linux.com>
> ---
> .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> index 01ec45b3b406..860ab58d87b0 100644
> --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> @@ -33,6 +33,7 @@ properties:
> - amlogic,meson8b-uart
> - amlogic,meson-gx-uart
> - amlogic,meson-s4-uart
> + - amlogic,meson-t7-uart
> - const: amlogic,meson-ao-uart
> - description: Always-on power domain UART controller on G12A SoCs
> items:
> @@ -46,6 +47,7 @@ properties:
> - amlogic,meson8b-uart
> - amlogic,meson-gx-uart
> - amlogic,meson-s4-uart
> + - amlogic,meson-t7-uart
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-06-21 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 13:32 [PATCH v3 0/3] Add Amlogic A311D2 and Khadas Vim4 Board Support Lucas Tanure
2023-06-21 13:32 ` [PATCH v3 1/3] dt-bindings: arm: amlogic: add Amlogic A311D2 bindings Lucas Tanure
2023-06-21 13:32 ` [PATCH v3 2/3] dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7 Lucas Tanure
2023-06-21 13:53 ` Krzysztof Kozlowski [this message]
2023-06-21 18:11 ` Conor Dooley
2023-06-22 5:32 ` Lucas Tanure
2023-06-22 6:05 ` Krzysztof Kozlowski
2023-06-22 6:43 ` Lucas Tanure
2023-06-22 7:11 ` Conor Dooley
2023-06-22 7:36 ` Lucas Tanure
2023-06-22 8:13 ` Neil Armstrong
2023-06-22 8:26 ` Lucas Tanure
2023-06-21 13:32 ` [PATCH v3 3/3] arm64: dts: meson-t7-a311d2-khadas-vim4: add initial device-tree Lucas Tanure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20f25e98-d02e-f914-c4e7-72bb9ddb1ae5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=art@khadas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nick@khadas.com \
--cc=robh+dt@kernel.org \
--cc=tanure@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®