Re: [PATCH v2 1/1] PCI : Refactoring error log prints for better readability

From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Onkarnarth <onkarnath.1@samsung.com>
Cc: <bhelgaas@google.com>, <helgaas@kernel.org>, <vigneshr@ti.com>,
	<s-vadapalli@ti.com>, <lpieralisi@kernel.org>, <kw@linux.com>,
	<robh@kernel.org>, <yue.wang@Amlogic.com>,
	<neil.armstrong@linaro.org>, <khilman@baylibre.com>,
	<jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com>,
	<thomas.petazzoni@bootlin.com>, <shawn.guo@linaro.org>,
	<lchuanhua@maxlinear.com>, <srikanth.thokala@intel.com>,
	<songxiaowei@hisilicon.com>, <wangbinghui@hisilicon.com>,
	<manivannan.sadhasivam@linaro.org>, <thierry.reding@gmail.com>,
	<jonathanh@nvidia.com>, <hayashi.kunihiko@socionext.com>,
	<mhiramat@kernel.org>, <pali@kernel.org>,
	<toan@os.amperecomputing.com>, <daire.mcnamara@microchip.com>,
	<conor.dooley@microchip.com>, <marek.vasut+renesas@gmail.com>,
	<shawn.lin@rock-chips.com>, <heiko@sntech.de>,
	<nirmal.patel@linux.intel.com>, <jonathan.derrick@linux.dev>,
	<kishon@kernel.org>, <jdmason@kudzu.us>, <dave.jiang@intel.com>,
	<rafael@kernel.org>, <lenb@kernel.org>, <mahesh@linux.ibm.com>,
	<oohall@gmail.com>, <linux-pci@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<r.thapliyal@samsung.com>,
	Maninder Singh <maninder1.s@samsung.com>
Subject: Re: [PATCH v2 1/1] PCI : Refactoring error log prints for better readability
Date: Tue, 21 May 2024 12:12:46 +0530	[thread overview]
Message-ID: <2227b0ed-a57f-4bca-8f3e-721bc2e2055a@ti.com> (raw)
In-Reply-To: <20240521061528.3559751-1-onkarnath.1@samsung.com>

On Tue, May 21, 2024 at 11:45:28AM +0530, Onkarnarth wrote:
> From: Onkarnath <onkarnath.1@samsung.com>

nitpick: In $subject:
s/Refactoring/Refactor
to follow the convention of using imperative mood.

> 
> As %pe is already introduced, it's better to use it in place of (%ld) or
> (%d) for printing error in logs. It will enhance readability of logs.
> 
> Error print style is more consistent now.
> 
> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> Co-developed-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Onkarnath <onkarnath.1@samsung.com>

Thank you for the patch. LGTM.

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

> ---
> Suggested by Bjorn Helgaas in below discussion
> https://patchwork.kernel.org/comment/25712288/
> 
> v1 -> v2: Added suggested by tag
> 
>  drivers/pci/bus.c                             |   2 +-
>  drivers/pci/controller/dwc/pci-dra7xx.c       |   2 +-
>  drivers/pci/controller/dwc/pci-meson.c        |  16 +--
>  drivers/pci/controller/dwc/pcie-armada8k.c    |   4 +-
>  drivers/pci/controller/dwc/pcie-histb.c       |   6 +-
>  drivers/pci/controller/dwc/pcie-intel-gw.c    |  10 +-
>  drivers/pci/controller/dwc/pcie-keembay.c     |   2 +-
>  drivers/pci/controller/dwc/pcie-kirin.c       |   6 +-
>  drivers/pci/controller/dwc/pcie-qcom-ep.c     |  18 +--
>  drivers/pci/controller/dwc/pcie-qcom.c        |  18 +--
>  drivers/pci/controller/dwc/pcie-tegra194.c    | 132 +++++++++---------
>  drivers/pci/controller/dwc/pcie-uniphier-ep.c |   2 +-
>  drivers/pci/controller/pci-aardvark.c         |   6 +-
>  drivers/pci/controller/pci-ftpci100.c         |   2 +-
>  drivers/pci/controller/pci-tegra.c            |  86 ++++++------
>  drivers/pci/controller/pci-xgene.c            |   4 +-
>  drivers/pci/controller/pcie-microchip-host.c  |   2 +-
>  drivers/pci/controller/pcie-rcar-host.c       |  14 +-
>  drivers/pci/controller/pcie-rockchip.c        |  34 ++---
>  drivers/pci/controller/vmd.c                  |   2 +-
>  drivers/pci/doe.c                             |   4 +-
>  drivers/pci/endpoint/functions/pci-epf-mhi.c  |   8 +-
>  drivers/pci/endpoint/functions/pci-epf-ntb.c  |   2 +-
>  drivers/pci/endpoint/functions/pci-epf-test.c |   4 +-
>  drivers/pci/endpoint/functions/pci-epf-vntb.c |   2 +-
>  drivers/pci/endpoint/pci-ep-cfs.c             |  12 +-
>  drivers/pci/endpoint/pci-epf-core.c           |  16 +--
>  drivers/pci/hotplug/acpiphp_core.c            |   2 +-
>  drivers/pci/hotplug/pciehp_core.c             |   8 +-
>  drivers/pci/hotplug/shpchp_core.c             |   4 +-
>  drivers/pci/of.c                              |   6 +-
>  drivers/pci/pci-driver.c                      |   4 +-
>  drivers/pci/pcie/dpc.c                        |   4 +-
>  drivers/pci/quirks.c                          |   2 +-
>  drivers/pci/setup-bus.c                       |   2 +-
>  drivers/pci/slot.c                            |   4 +-
>  drivers/pci/vgaarb.c                          |   2 +-
>  37 files changed, 227 insertions(+), 227 deletions(-)
> 

[...]

Regards,
Siddharth.

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic