mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Cc: neil.armstrong@linaro.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, jirislaby@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: serial: amlogic,meson-uart: Add compatible string for G12A
Date: Tue, 7 Mar 2023 09:47:26 +0100	[thread overview]
Message-ID: <227d9815-cf5f-6d2b-d52c-dbcc95729a59@linaro.org> (raw)
In-Reply-To: <20230306194223.1869814-2-martin.blumenstingl@googlemail.com>

On 06/03/2023 20:42, Martin Blumenstingl wrote:
> Amlogic G12A SoCs gained a new "divide XTAL by 2" bit. Everything else
> (we know about) is identical to the UART IP on GX (GXBB/GXL/GXM) SoCs.
> Add a new compatible string for this SoC so this new bit can be managed
> accordingly while keeping "amlogic,meson-gx-uart" as fallback compatible
> string.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> Changes from v1 -> v2:
> - make meson-gx-uart a valid compatible string for meson-g12a-uart
> 
> 
>  .../bindings/serial/amlogic,meson-uart.yaml   | 28 +++++++++++++------
>  1 file changed, 19 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> index 3cbdde85ed71..f3af0da8edaf 100644
> --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> @@ -26,21 +26,31 @@ properties:
>    compatible:
>      oneOf:
>        - description: Always-on power domain UART controller
> -        items:
> +        oneOf:
> +          - items:
> +              - enum:
> +                  - amlogic,meson6-uart
> +                  - amlogic,meson8-uart
> +                  - amlogic,meson8b-uart
> +                  - amlogic,meson-gx-uart
> +                  - amlogic,meson-s4-uart
> +              - const: amlogic,meson-ao-uart
> +          - items:
> +              - const: amlogic,meson-g12a-uart
> +              - const: amlogic,meson-gx-uart
> +              - const: amlogic,meson-ao-uart
> +      - description: Everything-Else power domain UART controller
> +        oneOf:
>            - enum:
>                - amlogic,meson6-uart
>                - amlogic,meson8-uart
>                - amlogic,meson8b-uart
>                - amlogic,meson-gx-uart
> +              - amlogic,meson-g12a-uart
>                - amlogic,meson-s4-uart
> -          - const: amlogic,meson-ao-uart
> -      - description: Everything-Else power domain UART controller
> -        enum:
> -          - amlogic,meson6-uart
> -          - amlogic,meson8-uart
> -          - amlogic,meson8b-uart
> -          - amlogic,meson-gx-uart
> -          - amlogic,meson-s4-uart
> +          - items:
> +              - const: amlogic,meson-g12a-uart
> +              - const: amlogic,meson-gx-uart

Difficult to review... You claim you add only g12a which seems like is
happening there but with some other changes. I see g12a three times and
a lot of reshuffling. I also see multiple oneOf, so something is clearly
wrong. oneOf is only one.

Best regards,
Krzysztof


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2023-03-07  9:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 19:42 [PATCH v2 0/3] meson-uart: Use "divide XTAL by 2" bit on G12A Martin Blumenstingl
2023-03-06 19:42 ` [PATCH v2 1/3] dt-bindings: serial: amlogic,meson-uart: Add compatible string for G12A Martin Blumenstingl
2023-03-07  8:47   ` Krzysztof Kozlowski [this message]
2023-03-06 19:42 ` [PATCH v2 2/3] tty: serial: meson: Add a new compatible string for the G12A SoC Martin Blumenstingl
2023-03-06 19:42 ` [PATCH v2 3/3] arm64: dts: meson-g12-common: Use the G12A UART compatible string Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=227d9815-cf5f-6d2b-d52c-dbcc95729a59@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®