mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: jbrunet@baylibre.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	christianshewitt@gmail.com, art@khadas.com, nick@khadas.com,
	gouwa@khadas.com, Artem Lapkin <email2tema@gmail.com>
Subject: Re: [PATCH] arm64: dts: meson: sm1-khadas-vim3l use one sound node configuration with VIM3
Date: Thu, 2 Sep 2021 15:31:13 +0200	[thread overview]
Message-ID: <247c746b-621c-5db0-25c0-1ef0d0a0d77e@baylibre.com> (raw)
In-Reply-To: <20210812051059.1103641-1-art@khadas.com>

Hi,

On 12/08/2021 07:10, Artem Lapkin wrote:
> Khadas VIM3L board sound configuration same as Khadas VIM3, its already
> defined in meson-khadas-vim3.dtsi and no need overwrite it with different
> card names and routing configurations.
> 
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
>  .../boot/dts/amlogic/meson-sm1-khadas-vim3l.dts     | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> index f2c098143..06de0b1ce 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> @@ -32,19 +32,6 @@ vddcpu: regulator-vddcpu {
>  		regulator-boot-on;
>  		regulator-always-on;
>  	};
> -
> -	sound {
> -		model = "G12B-KHADAS-VIM3L";
> -		audio-routing = "TDMOUT_A IN 0", "FRDDR_A OUT 0",
> -				"TDMOUT_A IN 1", "FRDDR_B OUT 0",
> -				"TDMOUT_A IN 2", "FRDDR_C OUT 0",
> -				"TDM_A Playback", "TDMOUT_A OUT",
> -				"TDMIN_A IN 0", "TDM_A Capture",
> -				"TDMIN_A IN 13", "TDM_A Loopback",
> -				"TODDR_A IN 0", "TDMIN_A OUT",
> -				"TODDR_B IN 0", "TDMIN_A OUT",
> -				"TODDR_C IN 0", "TDMIN_A OUT";
> -	};
>  };
>  
>  &cpu0 {
> 

Jerome could you quickly review this ?

Thanks,
Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2021-09-02 13:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  5:10 Artem Lapkin
2021-09-02 13:31 ` Neil Armstrong [this message]
2021-09-06  9:18   ` Jerome Brunet
2021-09-06 12:02     ` Art Nikpal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=247c746b-621c-5db0-25c0-1ef0d0a0d77e@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=art@khadas.com \
    --cc=christianshewitt@gmail.com \
    --cc=email2tema@gmail.com \
    --cc=gouwa@khadas.com \
    --cc=jbrunet@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick@khadas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®