From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] ARM64: dts: meson-gxbb: set reset for ethernet
Date: Mon, 6 Feb 2017 10:29:34 +0100 [thread overview]
Message-ID: <259f7102-591b-f251-5844-a864fa39e137@baylibre.com> (raw)
In-Reply-To: <ec31eddc-d286-d0bc-0bdb-ae9d5014d82e@gmail.com>
On 01/29/2017 03:07 PM, Heiner Kallweit wrote:
> Add reset control for ethernet.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 39a774ad..753fddf6 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -113,6 +113,8 @@
> <&clkc CLKID_FCLK_DIV2>,
> <&clkc CLKID_MPLL2>;
> clock-names = "stmmaceth", "clkin0", "clkin1";
> + resets = <&reset RESET_ETHERNET>;
> + reset-names = "stmmaceth";
> };
>
> &aobus {
>
Hi,
Actually this is a no-op since the Amlogic reset controller only supports "pulse" resets and the
STMMAC driver only supports "level" resets. If you want to use this reset, you must add the
corresponding support code in the meson8b glue code to call device_reset().
Neil
next prev parent reply other threads:[~2017-02-06 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 14:07 Heiner Kallweit
2017-02-06 9:29 ` Neil Armstrong [this message]
2017-02-07 20:43 ` Heiner Kallweit
2017-02-08 8:45 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=259f7102-591b-f251-5844-a864fa39e137@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®