Re: [PATCH v2] staging: media: meson: vdec: propagate devm_clk_get() errors

From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Alfie Varghese <alfievarghese22@gmail.com>, neil.armstrong@linaro.org
Cc: gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
	 linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	 linux-amlogic@lists.infradead.org, dan.carpenter@linaro.org,
	error27@gmail.com
Subject: Re: [PATCH v2] staging: media: meson: vdec: propagate devm_clk_get() errors
Date: Tue, 14 Jul 2026 10:28:48 -0400	[thread overview]
Message-ID: <263a79327f88e75a821abbbeb6f1dfa0448da86e.camel@ndufresne.ca> (raw)
In-Reply-To: <20260714140458.1276-1-alfievarghese22@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2003 bytes --]

Le mardi 14 juillet 2026 à 19:34 +0530, Alfie Varghese a écrit :
> vdec_probe() hardcodes -EPROBE_DEFER for all devm_clk_get() failures.
> This masks the actual error code returned by the clock framework, such
> as -ENOENT when a clock is not registered or -ENOMEM on allocation
> failure.
> 
> Return PTR_ERR() instead to propagate the real error to the caller.
> 
> Fixes: 4f75e7dfa6dc ("media: meson: vdec: add driver")
> Signed-off-by: Alfie Varghese <alfievarghese22@gmail.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  drivers/staging/media/meson/vdec/vdec.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
> index a039d925c0fe..fba1e7f88d81 100644
> --- a/drivers/staging/media/meson/vdec/vdec.c
> +++ b/drivers/staging/media/meson/vdec/vdec.c
> @@ -1026,24 +1026,24 @@ static int vdec_probe(struct platform_device *pdev)
>  	    core->platform->revision == VDEC_REVISION_SM1) {
>  		core->vdec_hevcf_clk = devm_clk_get(dev, "vdec_hevcf");
>  		if (IS_ERR(core->vdec_hevcf_clk))
> -			return -EPROBE_DEFER;
> +			return PTR_ERR(core->vdec_hevcf_clk);
>  	}
>  
>  	core->dos_parser_clk = devm_clk_get(dev, "dos_parser");
>  	if (IS_ERR(core->dos_parser_clk))
> -		return -EPROBE_DEFER;
> +		return PTR_ERR(core->dos_parser_clk);
>  
>  	core->dos_clk = devm_clk_get(dev, "dos");
>  	if (IS_ERR(core->dos_clk))
> -		return -EPROBE_DEFER;
> +		return PTR_ERR(core->dos_clk);
>  
>  	core->vdec_1_clk = devm_clk_get(dev, "vdec_1");
>  	if (IS_ERR(core->vdec_1_clk))
> -		return -EPROBE_DEFER;
> +		return PTR_ERR(core->vdec_1_clk);
>  
>  	core->vdec_hevc_clk = devm_clk_get(dev, "vdec_hevc");
>  	if (IS_ERR(core->vdec_hevc_clk))
> -		return -EPROBE_DEFER;
> +		return PTR_ERR(core->vdec_hevc_clk);
>  
>  	irq = platform_get_irq_byname(pdev, "vdec");
>  	if (irq < 0)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic