From: marex@denx.de (Marek Vasut)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 u-boot 1/3] usb: host: Add simple of glue driver for DWC3 USB Controllers integration
Date: Wed, 11 Apr 2018 16:59:39 +0200 [thread overview]
Message-ID: <2b758956-b970-8675-c4db-28f878524a63@denx.de> (raw)
In-Reply-To: <b4c270c1-201d-70b6-8a34-d458e211bb25@baylibre.com>
On 04/11/2018 04:53 PM, Neil Armstrong wrote:
> Hi Marek,
>
> On 11/04/2018 16:37, Marek Vasut wrote:
>> On 04/11/2018 04:29 PM, Neil Armstrong wrote:
>>> This is a port of the dwc3-of-simple driver from Linux to enable/deassert
>>> clock and resets of a simple DWC3 Controller HW glue.
>>>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>
>> Looks good, except can we reduce the number of ifdefs, ie. by using
>> empty functions if DM_* is not defined ?
>
> For reset, yes, for clock only the get_bulk and release_bulk...
Any reduction of the omnipresent ifdefs would be nice.
> Should I re-spin ?
That'd be nice, thanks.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-04-11 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 14:29 [PATCH v2 u-boot 0/3] Add USB Support for Amlogic Meson GXL SoCs Neil Armstrong
2018-04-11 14:29 ` [PATCH v2 u-boot 1/3] usb: host: Add simple of glue driver for DWC3 USB Controllers integration Neil Armstrong
2018-04-11 14:37 ` Marek Vasut
2018-04-11 14:53 ` Neil Armstrong
2018-04-11 14:59 ` Marek Vasut [this message]
2018-04-11 14:29 ` [PATCH v2 u-boot 2/3] usb: host: dwc3: Add support for multiple PHYs Neil Armstrong
2018-04-11 14:29 ` [PATCH v2 u-boot 3/3] phy: Add Amlogic Meson USB2 & USB3 Generic PHY drivers Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b758956-b970-8675-c4db-28f878524a63@denx.de \
--to=marex@denx.de \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®