From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94575FC9EC3 for ; Fri, 6 Mar 2026 23:29:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u/87IrptaqbM2ukpIOACaUd7N1pFNU8G7K1UVVLFT44=; b=vYd9hFgWS/fbdr 85emGpAanAtT5vf44Pg8vyE9vu71iroXEe9isoDwpcfyq9Pgpi1b9o5SpEFlPzY03GK/NNKh4uS3z Ny9uhaFusFyg4DOByUzvRfHVIsD5GDedvni//VPYJqA7zFOesJVQWstZYe+GzObp5wHtZdgf6nkB4 wBqp12VZlFT5FI/7D1n9JdLw2EjoCjbxsA6F7udtwW2btfzu37vlgT/fs55/lRPFWDCAirLShhv38 Ighi68u2J64C2jOaWK09KUndJp1EQhK5+G3sAaqmNgUcMks70BdiNw60ZyfGsKyR9irIS1KTyDZSA ZCnDUT6kRcvKVM6sS0AQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyebQ-00000004e35-2nPo; Fri, 06 Mar 2026 23:29:04 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyebO-00000004e1z-2lyA for linux-amlogic@lists.infradead.org; Fri, 06 Mar 2026 23:29:03 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-823c56765fdso5042053b3a.1 for ; Fri, 06 Mar 2026 15:29:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772839741; x=1773444541; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=jmuJidMV1Wwe0qpdw07DaES1yYrCFjR7mRIMJgUWNXw=; b=M2FzWy0p09SavNkPi4e0vqlGtG+EXGFtAlxBEEggFreTKg2S5NFhYwtggB57tvroUv brRdB33OQoVx4eZgzJn4kisDQfAmqWFOtwi3Wn6BIri5LDlX9f9xRkgIYtbk4M3atHWP IBlBsHaWzQSBC4KNdolje7LV7jZLhCm8RSzR9Dz6+chRvEvSYUWVu3rilK8y7YxWjgCj wqYobeBEAa/A4PM/5zYryij+f9Tg0ojzDhHGkHaWZL4qIBTcTjcHBwJZYfW5MMS43u8K wK/E+xlitfFyxfi74/v0hLxhJS19W0DpR0BCbxcBnq/ERzi0WQwwEdUAzpUByJQRWKoG zsqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772839741; x=1773444541; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jmuJidMV1Wwe0qpdw07DaES1yYrCFjR7mRIMJgUWNXw=; b=xQD9uuGii+vr1Y7B1f94oWmgubbGrIWcK7sejckiOLlzB6P7YrI/lMAXzLuruajYvh nXzZhC531jITekJ/bpGhY6lIRaaB53v97W2A2ZUrrQaAwTi8OQJSSX0FDpqE1i9UGnu0 77+yrPuoRrlSU47g56xk/VUBDqCIsjGAUrb6BJiA98TAjTMsEXAtAKC2SnfMFg209SPT WmUn3qSUBRz3vUM4K1M9xYpI5OTRxJFM21r7HN1rn81bxtv5wVK0f2i4NmMkCOgRYm2E Zw4m/Cy9QZIjfg2heSeXY2gHLt4Y3XYRylK5N2orE4ZXdG5EroDBe1N1YuS0oRZkV+Py mU6Q== X-Forwarded-Encrypted: i=1; AJvYcCXI4P2GOsDZO5a486OCfWxQGmONjhlfQAaAlUG9yoqU7h3N3dYQ+hDUAZRGIYr78fwFVwZrUOszUnX4Ynsu@lists.infradead.org X-Gm-Message-State: AOJu0YyGrN+SvmZg6sHdry93uMovE4RJNfjejEgmZQII6Yx7TQzWdN5Q uLNHP09ZQJcNLjO/soBAzbYS1cXoe8T2snhnHFJarqUfGygmHdKOh2fj X-Gm-Gg: ATEYQzyCXOuWUA4czAVnqz4LHF0hVK4rVcQd37dNh5o0qh51MBh7U4rkkrb12VfIaVj ZvYuRufrc2HrDm7os+XuZqMIwreRcu1tjwsblRIUCDbCMwrKkRW1v1vv0lGoPKc4LhzPws/6ob2 DR5Tvce10ST8NJO6xpnIYKwyKu5trytsw6TBCGjUwoMQ9/B3WiWSib4B8yT/8GZQEqzCt9paovh 4DrQAbWQ3L4KwfRvvJaszDnottUCigdAhL3GtmoefTPL5bvmUdNMKXcBCxMZrxPLNMWQhkbPvFK wTP5v5X/Te96KgfXyeG4zQIHgcfTCPAkSyWH13X/cJmK0AYAGDUwKN/jKa5ZXiOTqyMqU9Ms7yo +qVF1AdMbMEP2c1jKIVpy2aUKYBS3lYX+l6SHjW42NYhabkiOtEYUArSF1ECmbdNit+XE2BQ7co KU1WZBhYS/VbZ0lVPOH3GCs/wAUV2oiAzWtDf8 X-Received: by 2002:a05:6a00:9510:b0:829:8942:2c93 with SMTP id d2e1a72fcca58-829a2d86b43mr3749707b3a.9.1772839741072; Fri, 06 Mar 2026 15:29:01 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a48d3621sm3213092b3a.62.2026.03.06.15.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 15:29:00 -0800 (PST) Date: Fri, 6 Mar 2026 15:28:59 -0800 From: Guenter Roeck To: Bartosz Golaszewski Cc: Catalin Marinas , Will Deacon , Alexey Brodkin , Vineet Gupta , Scott Wood , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Dvorkin Dmitry , Wells Lu , Lee Jones , Pavel Machek , Wim Van Sebroeck , Mauro Carvalho Chehab , Greg Kroah-Hartman , Sebastian Reichel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-leds@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-pm@vger.kernel.org Subject: Re: [PATCH 10/14] watchdog: convert the Kconfig dependency on OF_GPIO to OF Message-ID: <2c6ad0ca-fd72-4bf5-9180-f45c20e60d37@roeck-us.net> References: <20260304-gpio-of-kconfig-v1-0-d597916e79e7@oss.qualcomm.com> <20260304-gpio-of-kconfig-v1-10-d597916e79e7@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260304-gpio-of-kconfig-v1-10-d597916e79e7@oss.qualcomm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260306_152902_712854_188753AC X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Mar 04, 2026 at 10:02:31AM +0100, Bartosz Golaszewski wrote: > OF_GPIO is selected automatically on all OF systems. Any symbols it > controls also provide stubs so there's really no reason to select it > explicitly. We could simply remove the dependency but in order to avoid > a new symbol popping up for everyone in make config - just convert it to > requiring CONFIG_OF. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index dc78729ba2a5d6e035ed3cbe5c2b631d11b76b20..ef200339a22a6f9c51a46c9c0b8466add74313e2 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -250,7 +250,7 @@ config DA9062_WATCHDOG > > config GPIO_WATCHDOG > tristate "Watchdog device controlled through GPIO-line" > - depends on OF_GPIO > + depends on OF AI feedback: Could this change inadvertently allow the driver to be selected when GPIOLIB is disabled? In drivers/gpio/Kconfig, OF_GPIO is defined inside the "if GPIOLIB" block, so it implicitly depends on GPIOLIB. By changing the dependency directly to OF, the GPIOLIB dependency is lost. If GPIOLIB is disabled, the driver will still compile because of the stubs in include/linux/gpio/consumer.h, but devm_gpiod_get() will unconditionally return -ENOSYS, causing the probe to fail. Since the driver's sole purpose is to control a watchdog via a GPIO line, should it be prevented from being configured without GPIOLIB by using something like: depends on OF && GPIOLIB It has a point. Please update. Thanks, Guenter > select WATCHDOG_CORE > help > If you say yes here you get support for watchdog device _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic