Re: [PATCH 4/6] drm: ci: Enable configs to fix mt8173 boot hang issue

From: David Heidelberg <david.heidelberg@collabora.com>
To: Vignesh Raman <vignesh.raman@collabora.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	dri-devel@lists.freedesktop.org,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: helen.koike@collabora.com, guilherme.gallo@collabora.com,
	sergi.blanch.torne@collabora.com, daniels@collabora.com,
	emma@anholt.net, robclark@freedesktop.org,
	gustavo.padovan@collabora.com, robdclark@google.com,
	anholt@google.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
	daniel@ffwll.ch, corbet@lwn.net, neil.armstrong@linaro.org,
	khilman@baylibre.com, jbrunet@baylibre.com,
	martin.blumenstingl@googlemail.com, heiko@sntech.de,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 4/6] drm: ci: Enable configs to fix mt8173 boot hang issue
Date: Fri, 8 Sep 2023 17:56:36 +0530	[thread overview]
Message-ID: <2dc6f9fa-06fb-44d8-97cb-6b5a983b7539@collabora.com> (raw)
In-Reply-To: <ff99380a-cb0d-dc6c-0442-7aa60d14cec2@collabora.com>

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1659 bytes --]

On 08/09/2023 13:23, Vignesh Raman wrote:

> Hi Angelo,
>
> On 07/09/23 16:16, AngeloGioacchino Del Regno wrote:
>> Il 25/08/23 14:24, Vignesh Raman ha scritto:
>>> Enable regulator
>>> Enable MT6397 RTC driver
>>>
>>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
>>> ---
>>>   drivers/gpu/drm/ci/arm64.config | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/ci/arm64.config 
>>> b/drivers/gpu/drm/ci/arm64.config
>>> index 817e18ddfd4f..ea7a6cceff40 100644
>>> --- a/drivers/gpu/drm/ci/arm64.config
>>> +++ b/drivers/gpu/drm/ci/arm64.config
>>> @@ -184,6 +184,8 @@ CONFIG_HW_RANDOM_MTK=y
>>>   CONFIG_MTK_DEVAPC=y
>>>   CONFIG_PWM_MTK_DISP=y
>>>   CONFIG_MTK_CMDQ=y
>>> +CONFIG_REGULATOR_DA9211=y
>>> +CONFIG_RTC_DRV_MT6397=y
>>
>> I wonder if it'd be a better idea to simply add those to the 
>> defconfig instead as
>>
>> CONFIG_REGULATOR_DA9211=m
>> CONFIG_RTC_DRV_MT6397=m
>>
>> Any opinion on this? Matthias? Anyone else?
>
> CONFIG_RTC_DRV_MT6397=m is already present in defconfig.
> We can also add CONFIG_REGULATOR_DA9211=m to defconfig.

We need add config snippet override for CONFIG_REGULATOR_DA9211=y 
because our CI don't have any initrd with modules, we just immediately 
continue boot from NFS, where we load rest of the boot non-essential 
modules.

For generic kernel, I assume CONFIG_REGULATOR_DA9211=m should be added.

David

>
> Regards,
> Vignesh

-- 
David Heidelberg
Consultant Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 695 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic