mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] reset: meson: enable level reset support on Meson8b
Date: Tue, 2 Jan 2018 13:49:38 +0100	[thread overview]
Message-ID: <30459dd9-78ef-e462-1c38-7048aebd0b40@baylibre.com> (raw)
In-Reply-To: <1514892915.5080.5.camel@pengutronix.de>

On 02/01/2018 12:35, Philipp Zabel wrote:
> Hi Martin,
> 
> On Tue, 2017-12-26 at 12:50 +0100, Martin Blumenstingl wrote:
>> Commit a5a10afe04ef ("reset: meson: add level reset support for GX SoC
>> family") only enabled the level resets for the newer GX SoC family.
>> However, the older 32-Meson SoCs (Meson8, Meson8b and Meson8m2) also
>> support level resets using the same offset as the newer GX SoCs.
>>
>> This removes the separation between Meson8b and the GX SoCs from the
>> reset-meson driver to enable the level resets also on Meson8b.
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> Thank you for the patch.?It looks fine to me, not knowing the hardware
> details.
> The referenced commit made it sound like reset level handling on Meson8
> is different from GX, though. Could somebody clarify?
> 
> regards
> Philipp
> 

Hi Philipp,

This is highly undocumented and needs reading the vendor source code and experimenting,
this patch is ok for me. Seems the register mapping did not change for a long time since
it's still the same on the latest AXG family.

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Neil

  reply	other threads:[~2018-01-02 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-26 11:50 Martin Blumenstingl
2018-01-02 11:35 ` Philipp Zabel
2018-01-02 12:49   ` Neil Armstrong [this message]
2018-01-02 13:01     ` Philipp Zabel
2018-01-02 21:53       ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30459dd9-78ef-e462-1c38-7048aebd0b40@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®