From: ccaione@baylibre.com (Carlo Caione)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH u-boot 10/19] pinctrl: meson: add axg support
Date: Tue, 20 Nov 2018 14:06:24 +0000 [thread overview]
Message-ID: <348976107da522ffe1546706b8429f8d3f14b3b1.camel@baylibre.com> (raw)
In-Reply-To: <1541777218-472-11-git-send-email-narmstrong@baylibre.com>
On Fri, 2018-11-09 at 16:26 +0100, Neil Armstrong wrote:
> From: Jerome Brunet <jbrunet@baylibre.com>
>
> This adds support for the Amlogic AXG SoC pinctrl and GPIO controller
> using a specific set of pinctrl functions which differs from the GX
> SoCs.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
/cut
> +static int meson_axg_gpio_request(struct udevice *dev,
> + unsigned int offset, const char
> *label)
> +{
> + return meson_axg_pmx_update_function(dev, offset, 0);
> +}
Hey Neil,
this should be:
meson_axg_pmx_update_function(dev->parent, offset, 0);
since you want to pass the pinctrl udevice (not the gpio one) otherwise
you get a Synchronous Abort when trying to access the pinctrl priv data
(and you can crash the board with `=> gpio input aobus-banks10`).
Cheers,
--
Carlo Caione
next prev parent reply other threads:[~2018-11-20 14:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 15:26 [PATCH u-boot 00/19] Amlogic Meson cleanup for AXG SoC support Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 01/19] ARM: meson: clean-up platform selection Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 02/19] configs: meson: remove unnecessary MESON_FDTFILE_SETTING Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 03/19] board: amlogic: remove p212 derivatives Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 04/19] board: amlogic: move khadas-vim2 as q200 ref board Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 05/19] board: amlogic: factorise gxbb boards Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 06/19] ARM: rework amlogic configuration Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 07/19] configs: meson: change default load addresses Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 08/19] pinctrl: meson: rework gx pmx function Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 09/19] pinctrl: meson: select generic pinctrl Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 10/19] pinctrl: meson: add axg support Neil Armstrong
2018-11-20 14:06 ` Carlo Caione [this message]
2018-11-20 14:47 ` Carlo Caione
2018-11-21 9:34 ` Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 11/19] clk: meson: add static to meson_gates table Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 12/19] clk: meson: silence debug print Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 13/19] ARM: meson: rework soc arch file to prepare for new SoC Neil Armstrong
2018-11-20 21:11 ` [U-Boot] " Loic Devulder
2018-11-21 9:34 ` Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 14/19] ARM: meson: Add support for AXG family Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 15/19] ARM: dts: Sync Amlogic Meson AXG DT from Linux 4.20-rc1 Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 16/19] clk: Add clock driver for AXG Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 17/19] board: amlogic: add support for S400 board Neil Armstrong
2018-11-20 21:08 ` [U-Boot] " Loic Devulder
2018-11-21 9:32 ` Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 18/19] ARM: meson: factorize common code out amlogic's boards Neil Armstrong
2018-11-09 15:26 ` [PATCH u-boot 19/19] ARM: meson: Add boot device discovery Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348976107da522ffe1546706b8429f8d3f14b3b1.camel@baylibre.com \
--to=ccaione@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®