From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH u-boot 2/2] arm: Add Khadas VIM support based on Meson GXL family
Date: Wed, 22 Nov 2017 12:13:33 +0100 [thread overview]
Message-ID: <36646152-4949-d18c-bfff-1abb99fad594@baylibre.com> (raw)
In-Reply-To: <CAPnjgZ1vzkGoYSTDw+H=Puy=nXADHXdYxrPatMMtRE-gUT3_RQ@mail.gmail.com>
On 21/11/2017 05:09, Simon Glass wrote:
> Hi Neil,
>
> On 20 November 2017 at 08:04, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> This adds platform code for the Khadas VIM board based on a
>> Meson GXL (S905X) SoC with the Meson GXL configuration.
>>
>> This initial submission supports UART, MMC/SDCard and Ethernet with the
>> Internal RMII PHY.
>>
>> The meson-gxl-s905x-khadas-vim.dts is synchronised from the linux 4.13
>> stable tree as of 4.13.8.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> arch/arm/dts/Makefile | 3 +-
>> arch/arm/dts/meson-gxl-s905x-khadas-vim.dts | 137 ++++++++++++++++++++++++++++
>> arch/arm/mach-meson/Kconfig | 9 ++
>> board/amlogic/khadas-vim/Kconfig | 12 +++
>> board/amlogic/khadas-vim/MAINTAINERS | 6 ++
>> board/amlogic/khadas-vim/Makefile | 8 ++
>> board/amlogic/khadas-vim/README | 96 +++++++++++++++++++
>> board/amlogic/khadas-vim/khadas-vim.c | 58 ++++++++++++
>> configs/khadas-vim_defconfig | 35 +++++++
>> include/configs/khadas-vim.h | 24 +++++
>> 10 files changed, 387 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm/dts/meson-gxl-s905x-khadas-vim.dts
>> create mode 100644 board/amlogic/khadas-vim/Kconfig
>> create mode 100644 board/amlogic/khadas-vim/MAINTAINERS
>> create mode 100644 board/amlogic/khadas-vim/Makefile
>> create mode 100644 board/amlogic/khadas-vim/README
>> create mode 100644 board/amlogic/khadas-vim/khadas-vim.c
>> create mode 100644 configs/khadas-vim_defconfig
>> create mode 100644 include/configs/khadas-vim.h
>
> Sees like quite a bit of duplication with the previous patch,
> including the README. Can you fix this please?
For the README part, no, because they are quite different boards and
the instructions looks similar but uses quite different vendor
source to generate the ATF blobs.
For the board.c file, yes, I can definitely add a common ethernet
setup function to avoid duplication.
>
> - Simon
>
prev parent reply other threads:[~2017-11-22 11:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 15:04 [PATCH u-boot 0/2] Add support for Amlogic GXL Based SBCs Neil Armstrong
2017-11-20 15:04 ` [PATCH u-boot 1/2] arm: Add LibreTech CC support based on Meson GXL family Neil Armstrong
2017-11-21 4:08 ` Simon Glass
2017-11-22 11:11 ` Neil Armstrong
2017-11-20 15:04 ` [PATCH u-boot 2/2] arm: Add Khadas VIM " Neil Armstrong
2017-11-21 4:09 ` Simon Glass
2017-11-22 11:13 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36646152-4949-d18c-bfff-1abb99fad594@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®