mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/7] clocksource: Rename CLOCKSOURCE_OF_DECLARE
Date: Sun, 28 May 2017 16:20:03 +0200	[thread overview]
Message-ID: <376de2ec-c557-8541-9480-66472bd153a5@linaro.org> (raw)
In-Reply-To: <CACRpkdZbVv94hE9Gg+xiH2dxJANo-fPwLSek+BE4QwWWWWUixw@mail.gmail.com>

On 28/05/2017 15:48, Linus Walleij wrote:
> On Sat, May 27, 2017 at 11:58 AM, Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
> 
>> The CLOCKSOUCE_OF_DECLARE macro is used widely for the timers to declare the
>> clocksource at early stage. However, this macro is also used to initialize
>> the clockevent if any, or the clockevent only.
>>
>> It was originally suggested to declare another macro to initialize a
>> clockevent, so in order to separate the two entities even they belong to the
>> same IP. This was not accepted because of the impact on the DT where splitting
>> a clocksource/clockevent definition does not make sense as it is a Linux
>> concept not a hardware description.
>>
>> On the other side, the clocksource has not interrupt declared while the
>> clockevent has, so it is easy from the driver to know if the description is
>> for a clockevent or a clocksource, IOW it could be implemented at the driver
>> level.
>>
>> So instead of dealing with a named clocksource macro, let's use a more generic
>> one: TIMER_OF_DECLARE.
>>
>> The patch has not functional changes.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>'
> 
> This makes the macro make sense and I had this idea one time too.
> Awesome.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks Linus for reviewing the series.

  -- Daniel

-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2017-05-28 14:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1495879129-28109-1-git-send-email-daniel.lezcano@linaro.org>
2017-05-27  9:58 ` Daniel Lezcano
2017-05-28 13:48   ` Linus Walleij
2017-05-28 14:20     ` Daniel Lezcano [this message]
2017-05-29  7:39   ` Heiko Stübner
2017-05-29  8:00   ` Neil Armstrong
2017-05-29  8:41   ` Arnd Bergmann
2017-05-29  8:48     ` Daniel Lezcano
2017-05-29  9:57       ` Arnd Bergmann
2017-05-29 10:55         ` Daniel Lezcano
2017-05-29 11:21           ` Arnd Bergmann
2017-05-29 13:25   ` Matthias Brugger
2017-05-31  7:11   ` Patrice CHOTARD
2017-05-31  8:19   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=376de2ec-c557-8541-9480-66472bd153a5@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®