mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: jramirez@baylibre.com (Jorge Ramirez-Ortiz)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] ARM64: dts: meson: enable passing MAC addr on u-boot environment
Date: Wed, 17 Jan 2018 09:44:08 +0100	[thread overview]
Message-ID: <39648f56-81de-80c7-2795-fd898b9b7395@baylibre.com> (raw)
In-Reply-To: <dbbf50b8-7911-14d3-7357-e9f153b1ab71@baylibre.com>

On 01/17/2018 09:38 AM, Neil Armstrong wrote:
> Hi Jorge,
>
> On 16/01/2018 18:13, Jorge Ramirez-Ortiz wrote:
>> From: Jorge Ramirez-Ortiz <jramirez@baylibre.org>
>>
>> With the adequate configuration settings, u-boot will loop through the
>> list of aliases looking for "ethernetX".
>>
>> By adding an ethernet alias, u-boot can fixup the local-mac-address
>> property in the kernel's device tree using a value held in its
>> environment variable ethaddr.
>>
>> Signed-off-by: Jorge Ramirez-Ortiz <jramirez@baylibre.org>
>> ---
>>   arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
>> index 68d2c90..8ed2a98 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
>> @@ -18,6 +18,7 @@
>>   
>>   	aliases {
>>   		serial0 = &uart_AO;
>> +		ethernet = &ethmac;
> Isn't it ethernet0 instead ?

uboot can take both (ethernet or ethernet%i)
I just double checked amlogics uboot and you are right it needs ethernet%i

so will fix


>
>>   	};
>>   
>>   	chosen {
>>
> It would be great to have this on all boards with ethernet enabled.

yes will post a new version shortly


>
> Neil
>

      reply	other threads:[~2018-01-17  8:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1516122805-20227-1-git-send-email-jramirez@baylibre.com>
2018-01-17  8:38 ` Neil Armstrong
2018-01-17  8:44   ` Jorge Ramirez-Ortiz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39648f56-81de-80c7-2795-fd898b9b7395@baylibre.com \
    --to=jramirez@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®