Re: [RFC PATCH v2 0/7] Add ethernet support for the Amlogic T7

From: Andrew Lunn <andrew@lunn.ch>
To: Lucas Tanure <tanure@linux.com>
Cc: xianwei.zhao@amlogic.com, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/7] Add ethernet support for the Amlogic T7
Date: Fri, 9 Oct 2026 14:13:24 +0200	[thread overview]
Message-ID: <3a037c87-e4c5-4a4e-9522-cf505e1c6399@lunn.ch> (raw)
In-Reply-To: <CAJX_Q+2au4x99kj=UBqn4joQCM3-D2kbaJ0zro9Y4RXka7ePvQ@mail.gmail.com>

On Fri, Oct 09, 2026 at 06:59:49AM +0100, Lucas Tanure wrote:
> On Wed, Oct 7, 2026 at 2:01 PM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Wed, Oct 07, 2026 at 09:26:20AM +0100, Lucas Tanure wrote:
> > > The T7 pairs a Synopsys gigabit MAC with the same glue registers the
> > > G12A has, but nothing described it. This adds the binding, the driver
> > > support and the device tree nodes, and enables the port on the Khadas
> > > VIM4.
> > >
> > > Unlike the G12A, the controller reaches DRAM through a pipeline stage
> > > with a gate of its own, sys_ampipe_eth. Nothing else claims it, so
> > > clk_disable_unused switches it off and transfers stop.
> > >
> > > v2 changes the RGMII delays, after review. phy-mode describes the
> > > board, not which chip adds the delay, so this board is rgmii-id.
> > > dwmac-meson8b did the opposite, and ignored the *-internal-delay-ps
> > > properties. Patch 1 fixes that. The VIM4 needs it because the RTL8211F
> > > transmit delay does not work here.
> >
> > What is special about the RTL8211F?
> Maybe nothing, it may be this board. I cannot tell from here.

Yes, look at my other reply. The RTL8211F is very likely correct. It
is the MAC drivers handling of delays which is broken. You get to fix
it for this new device.

   Andrew

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic