From: Zhentao Guo <zhentao.guo@amlogic.com>
To: Nicolas Dufresne <nicolas@ndufresne.ca>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH RFC v2 2/3] decoder: Add V4L2 stateless H.264 decoder driver
Date: Tue, 16 Dec 2025 10:36:17 +0800 [thread overview]
Message-ID: <3b3f890c-2649-4a29-a620-203d4a72688e@amlogic.com> (raw)
In-Reply-To: <04287d0b6207c98f24112b492b9ee52f0889da39.camel@ndufresne.ca>
在 2025/12/15 21:58, Nicolas Dufresne 写道:
> Le lundi 15 décembre 2025 à 10:15 +0800, Zhentao Guo a écrit :
>> 在 2025/12/12 21:51, Nicolas Dufresne 写道:
>>> Hi,
>>>
>>> Le vendredi 12 décembre 2025 à 12:11 +0800, Zhentao Guo a écrit :
>>>>> strcpy() would be the preferred helper for this, no need to fill the
>>>>> leading
>>>>> zero liek this, see include/linux/string.h
>>>> Ok, it should be more suitable to use strcpy.
>>> I have to correct myself, I meant to suggest strscpy(dst, src, size).
>>> Passing
>>> the size for safety seems important, and unlike strncpy() it takes care of
>>> the
>>> leading zero.
>> Yes, we use strscpy() for copying all the strings.
> Indeed, I had miss-read, then you simply need to remove the code you added to
> force the last byte to be 0, this is not needed with that function.
Yes, I checked the function strscpy too. It will add the \0 if the
parameter 'size' is proper. We will remove this step in our code.
> Nicolas
>
>>> Nicolas
>> Thanks
>>
>> Zhentao
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2025-12-16 2:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 3:32 [PATCH RFC v2 0/3] Add Amlogic stateless H.264 video decoder for S4 Zhentao Guo via B4 Relay
2025-11-24 3:32 ` [PATCH RFC v2 1/3] media: dt-bindings: Add Amlogic V4L2 video decoder Zhentao Guo via B4 Relay
2025-11-25 11:31 ` Krzysztof Kozlowski
2025-11-25 11:45 ` Zhentao Guo
2025-12-16 23:43 ` Martin Blumenstingl
2025-12-17 2:38 ` Zhentao Guo
2025-11-24 3:32 ` [PATCH RFC v2 2/3] decoder: Add V4L2 stateless H.264 decoder driver Zhentao Guo via B4 Relay
2025-12-11 19:53 ` Nicolas Dufresne
2025-12-12 4:11 ` Zhentao Guo
2025-12-12 13:51 ` Nicolas Dufresne
2025-12-15 2:15 ` Zhentao Guo
2025-12-15 13:58 ` Nicolas Dufresne
2025-12-16 2:36 ` Zhentao Guo [this message]
2025-12-16 2:36 ` Zhentao Guo
2025-11-24 3:32 ` [PATCH RFC v2 3/3] arm64: dts: amlogic: Add video decoder driver support for S4 SOCs Zhentao Guo via B4 Relay
2025-11-24 14:28 ` [PATCH RFC v2 0/3] Add Amlogic stateless H.264 video decoder for S4 Rob Herring
2025-11-25 3:24 ` Zhentao Guo
2025-11-25 11:29 ` Krzysztof Kozlowski
2025-11-25 11:47 ` Zhentao Guo
2025-11-25 10:55 ` Ferass El Hafidi
2025-11-25 11:15 ` Zhentao Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b3f890c-2649-4a29-a620-203d4a72688e@amlogic.com \
--to=zhentao.guo@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas@ndufresne.ca \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox