From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29976C83038 for ; Tue, 1 Jul 2025 17:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WogQLV15GyEFfris4/R+UX4vCWJEW3UnW7X3N03xoiI=; b=r5xqJkGfH+A4c6 IgmSF3al6pEtr4pTt7pAJ9rjbNh/ErsR1dpSJ3rvfRwu92dGeMQ/7QiYbkKysdUhqGwkh3n20Yhpg y+VWoA5q/GDMDuqrO0ao1xEQy8aTHt7ULFUDS9Uz2GgfIvoXVopE7QyjjX6BYcjF872zjIk1jOzDg oiyOh6QEDMh+zB8aGZ+OKmw7VCVx+iEcgCcVnpQ0heHKaJ/Ma+3ZCIDhuLcHR2wjSlHubnZz3HpbC dvBgFRjK5z5ilU8Q4DkQ8E/K5wRUGYQla2PmTClTkOr6rhTLGSpQ3ao/3bG/3QN6R6TwjsZwkTVoz ospfyZgmKvDDwxVNq25A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWfEz-00000006Hd0-25AY; Tue, 01 Jul 2025 17:57:57 +0000 Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWcjK-00000005rIw-3xqL for linux-amlogic@lists.infradead.org; Tue, 01 Jul 2025 15:17:09 +0000 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-2efb0b03e40so1005420fac.0 for ; Tue, 01 Jul 2025 08:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1751383025; x=1751987825; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kto2WDWq8SXrCfQMl14bP+htdglCH2HfwzImspNOE2s=; b=tFTXD12EL3sjW5iY7vNmcQuotBePn2TCf+cUQW64Gb70ZQIIpWd8oSEOd48POCxqjd Ot+InkY1dEqDYqkcb9EOB+Xg6Akh5wciXxOlQ4ufarAUgWoYgvLvqM/zKH2QjCsZYJ9d 7PQ+o1CITfPfZoRi5ehtkYhXrJPYodfNyPAHoPcatKTF4JvfwMHat8tmdp8pEQh0VFKz YgXBaHxRTlitXFqaHTk4xMU/DR/5YPxH+9v0za4cbUcqWJttkuOiVHAP3mEpnO2t9uPy vDi+GScCQ8EL5k/+yJlf4uGhympo4QGBWcRkqg2rUsBnOqDQBUJ2B4CS/JKF8E2Y5v9C P+IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751383025; x=1751987825; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kto2WDWq8SXrCfQMl14bP+htdglCH2HfwzImspNOE2s=; b=AjoEePEXywXPQimiQbjgk1KUP3cmuTbctDNCSX1NeSJ0Vc0OyIPOlgwaqmN+Thas5s J5DcFPs8EPQ2Uby7IWsRSjiHMhkA2BrVYP5Pf31DAUF0DETbcVaRXqmu6Iqy/ptQuOvg eyl1mvYNB4BjvBQBTb8pFesgjE81vCx2QxvYkRZFXyfK/PpkrP/2SzOUU4UP2Jb1YlCl sMupKT0fJX5faNAwrWML+sXKWP34qUWhueUXbkzgu0MVXE2lmb+kKrTIgilzitgXFYW2 20jy8TbfQzXDxpM0aRXt22ONXi80Xk1qCCv/1zvp4ETu8np1xsC217urmW9S0lnxIZlR 9gTA== X-Forwarded-Encrypted: i=1; AJvYcCVqfa7DFbbbgqYIyywXnQgMf4+tdKXBwx8XNRSxwKHchOMUeiKLBKEpkfo2PR/cR+Y2XZ7FjGPyuG6TLL7p@lists.infradead.org X-Gm-Message-State: AOJu0YyubREhNwuIZZYblfOyDkAYX7CUGB++EOJ5ngbTtHXBZ+hTd+5f eVaH8q9UzqKZs0GDjx55rIdGkAXC3WG388Z0WseBxrnFnhQVO01nAkAteJEgfoy9UcI= X-Gm-Gg: ASbGnct9bKP01NdErpfzxOnClJEOJRLREJsSmB8Yf7iZXh5VlOwr6zg3wi4ahfHWEOh IRoq7hXwXLs5g12YVlWA0nRVZOP2jJFnldZz8Kg4f8IyxMpQIabM6uHO5kWf+sGvkXJsKUgKz6w VN+H+oBHmv6utobGSRsJWUIdTJWhze5J4CCqsDp6Mf3RQpur+JnzYKD3TLmD5CcCZxJG63a2NCH R1gK5+B+fkzYHt9NHcMRgwLIHZEwsERmXf9h4l7JOimDr56IG1ScQBFY/vfEoIvP4VmZ5IN3cOv IEsvOWZRYJTFbo/XJBH4g7rwJEHA1yzlc5PoppqHY5RTqUm+W09x/IF5dQgDXz/5YbigVXg9png PUKS4O8CDf+EzaUksc4HlOjtJRb/5cyGlxvIq19c= X-Google-Smtp-Source: AGHT+IGFKFZEsYZ4erbtAtqvl8tEHdHdyZFtcG8OKzWXPDqsQnJB5BtiKcEBEjaczDbwqY+Qnse9tA== X-Received: by 2002:a05:6871:82a:b0:2c7:6f57:3645 with SMTP id 586e51a60fabf-2efed67879emr12142176fac.18.1751383010329; Tue, 01 Jul 2025 08:16:50 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:70a7:ca49:a250:f1d5? ([2600:8803:e7e4:1d00:70a7:ca49:a250:f1d5]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2efd50fb14esm3319606fac.42.2025.07.01.08.16.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 08:16:49 -0700 (PDT) Message-ID: <3df2c424-297e-4538-b350-5c465b22fa39@baylibre.com> Date: Tue, 1 Jul 2025 10:16:47 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove error prints for devm_add_action_or_reset() To: Waqar Hameed , Vignesh Raghavendra , Julien Panis , William Breathitt Gray , Linus Walleij , Bartosz Golaszewski , Peter Rosin , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Matthias Brugger , AngeloGioacchino Del Regno , Matteo Martelli , Heiko Stuebner , Francesco Dolcini , =?UTF-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , Hugo Villeneuve , Subhajit Ghosh , Mudit Sharma , Gerald Loacker , Song Qiang , Crt Mori , Dmitry Torokhov , Ulf Hansson , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Alim Akhtar , Sebastian Reichel , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Han Xu , Haibo Chen , Yogesh Gaur , Mark Brown , Avri Altman , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Souradeep Chowdhury , Greg Kroah-Hartman , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Pierre-Louis Bossart , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: kernel@axis.com, linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, imx@lists.linux.dev, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org References: Content-Language: en-US From: David Lechner In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250701_081706_997642_D7BF70C7 X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 7/1/25 10:03 AM, Waqar Hameed wrote: > When `devm_add_action_or_reset()` fails, it is due to a failed memory > allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do > anything when error is `-ENOMEM`. Therefore, remove the useless call to > `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just > return the value instead. > > Signed-off-by: Waqar Hameed > --- I can't speak for all subsystems, but this would probably be acceptable in the iio subsystem. However, I don't think anyone is going to accept a patch that touches all of these files at the same time across subsystems. So I would suggest to split this up into one patch per driver and create one series per subsystem. This way, each subsystem isn't bothered by unrelated patches that they don't particularly need to care about. And note that some subsystems like net have additional expectations, e.g for the patch subject so that it gets picked up by automated tools, so be sure to check the docs for this. _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic