Re: [PATCH v6 3/4] arm64: dts: amlogic: t7: Add thermal zones

[Ronald Claveau <linux-kernel-dev@aliel.fr>]

On 10/15/26 8:00 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] dts: thermal trip points labeled as 'hot' are incorrectly typed as 'passive'
> --
> 
> commit f22129efed7c6439714c1c2501834a6c01be9e9e
> Author: Ronald Claveau <linux-kernel-dev@aliel.fr>
> 
> arm64: dts: amlogic: t7: Add thermal zones
> 
> This commit adds thermal zones for all six sensors (a53, a73, gpu, nna,
> vpu, and hevc) to the amlogic t7 device tree configuration.
> 
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> index c81632d3984e8..454a042865a5a 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> 
> [ ... ]
> 
>> +		gpu_thermal: gpu-thermal {
>> +			polling-delay = <1000>;
>> +			polling-delay-passive = <100>;
>> +			thermal-sensors = <&gpu_tsensor>;
>> +
>> +			trips {
>> +				gpu_passive: gpu-passive {
>> +					temperature = <95000>;
>> +					hysteresis = <5000>;
>> +					type = "passive";
>> +				};
>> +
>> +				gpu_hot: gpu-hot {
>> +					temperature = <105000>;
>> +					hysteresis = <5000>;
>> +					type = "passive";
> 
> [Severity: Medium]
> Does this incorrectly set the trip type for gpu-hot to "passive" instead
> of "hot"? The thermal subsystem will treat this as a passive trip point,
> meaning the standard hot thermal events won't trigger at the 105°C
> threshold.
> 
>> +				};
> 
> [ ... ]
> 
>> +		hevc_thermal: hevc-thermal {
>> +			polling-delay = <1000>;
>> +			polling-delay-passive = <100>;
>> +			thermal-sensors = <&hevc_tsensor>;
>> +
>> +			trips {
>> +				hevc_passive: hevc-passive {
>> +					temperature = <95000>;
>> +					hysteresis = <5000>;
>> +					type = "passive";
>> +				};
>> +
>> +				hevc_hot: hevc-hot {
>> +					temperature = <105000>;
>> +					hysteresis = <5000>;
>> +					type = "passive";
> 
> [Severity: Medium]
> Similarly, should the type for hevc-hot be "hot" rather than "passive"?
> 
>> +				};
> 
> [ ... ]
> 
>> +		nna_thermal: nna-thermal {
>> +			polling-delay = <1000>;
>> +			polling-delay-passive = <100>;
>> +			thermal-sensors = <&nna_tsensor>;
>> +
>> +			trips {
>> +				nna_passive: nna-passive {
>> +					temperature = <95000>;
>> +					hysteresis = <5000>;
>> +					type = "passive";
>> +				};
>> +
>> +				nna_hot: nna-hot {
>> +					temperature = <105000>;
>> +					hysteresis = <5000>;
>> +					type = "passive";
> 
> [Severity: Medium]
> Does this nna-hot trip point also need its type updated to "hot" so that
> it behaves distinctly from the passive trip point?
> 
>> +				};
> 
> [ ... ]
> 
>> +		vpu_thermal: vpu-thermal {
>> +			polling-delay = <1000>;
>> +			polling-delay-passive = <100>;
>> +			thermal-sensors = <&vpu_tsensor>;
>> +
>> +			trips {
>> +				vpu_passive: vpu-passive {
>> +					temperature = <95000>;
>> +					hysteresis = <5000>;
>> +					type = "passive";
>> +				};
>> +
>> +				vpu_hot: vpu-hot {
>> +					temperature = <105000>;
>> +					hysteresis = <5000>;
>> +					type = "passive";
> 
> [Severity: Medium]
> Is this another instance where the vpu-hot type was intended to be
> "hot" rather than "passive"?
> 
>> +				};
> 

You right, I will change them on next version.

-- 
Best regards,
Ronald

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic