From: Neil Armstrong <neil.armstrong@linaro.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Zelong Dong <zelong.dong@amlogic.com>,
Conor Dooley <conor.dooley@microchip.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh@kernel.org>,
kelvin.zhang@amlogic.com
Subject: Re: [PATCH v6 1/3] dt-bindings: reset: Add compatible for Amlogic A4/A5 Reset Controller
Date: Fri, 9 May 2025 17:39:11 +0200 [thread overview]
Message-ID: <40fe47b4-9373-4afe-a5ef-1b584b3ba26f@linaro.org> (raw)
In-Reply-To: <168c0dc2b1a9ebabbfd993e3a516dbf96d809f47.camel@pengutronix.de>
On 05/05/2025 14:53, Philipp Zabel wrote:
> Hi Neil,
>
> On Mo, 2025-05-05 at 14:30 +0200, Neil Armstrong wrote:
>> Hi Philipp,
>>
>> On 11/04/2025 13:38, Kelvin Zhang via B4 Relay wrote:
>>> From: Zelong Dong <zelong.dong@amlogic.com>
>>>
>>> Add compatibles for Amlogic A4 and A5 reset controllers,
>>> which fall back to 'amlogic,meson-s4-reset'.
>>>
>>> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
>>> Link: https://lore.kernel.org/r/20240918074211.8067-2-zelong.dong@amlogic.com
>>> Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com>
>>> ---
>>> .../bindings/reset/amlogic,meson-reset.yaml | 22 ++++++++++++++--------
>>> 1 file changed, 14 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> index 695ef38a7bb346c92b4cf428e7615d45682c940a..150e95c0d9bed74c7045942610a311114a257889 100644
>>> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> @@ -12,14 +12,20 @@ maintainers:
>>>
>>> properties:
>>> compatible:
>>> - enum:
>>> - - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
>>> - - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs
>>> - - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs
>>> - - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
>>> - - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs
>>> - - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
>>> - - amlogic,t7-reset
>>> + oneOf:
>>> + - enum:
>>> + - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
>>> + - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs
>>> + - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs
>>> + - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
>>> + - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs
>>> + - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
>>> + - amlogic,t7-reset
>>> + - items:
>>> + - enum:
>>> + - amlogic,a4-reset
>>> + - amlogic,a5-reset
>>> + - const: amlogic,meson-s4-reset
>>>
>>> reg:
>>> maxItems: 1
>>>
>>
>> Do you plan to take this change ?
>>
>> It has been laying around on the list for a while now, I plan
>> to apply it in my amlogic/drivers tree at the end of the week.
>
> I thought you'd pick it up together with the dts patches [1].
Sorry I missed this... applied it.
Thanks,
Neil
>
> [1] https://lore.kernel.org/all/a5d9b775dd860d8f2bbf174300a2e3161b654035.camel@pengutronix.de/
>
>
> regards
> Philipp
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2025-05-09 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 11:38 [PATCH v6 0/3] Add support for Amlogic A4/A5 Reset Kelvin Zhang via B4 Relay
2025-04-11 11:38 ` [PATCH v6 1/3] dt-bindings: reset: Add compatible for Amlogic A4/A5 Reset Controller Kelvin Zhang via B4 Relay
2025-05-05 12:30 ` Neil Armstrong
2025-05-05 12:53 ` Philipp Zabel
2025-05-09 15:39 ` Neil Armstrong [this message]
2025-04-11 11:38 ` [PATCH v6 2/3] arm64: dts: amlogic: Add A4 " Kelvin Zhang via B4 Relay
2025-04-11 11:38 ` [PATCH v6 3/3] arm64: dts: amlogic: Add A5 " Kelvin Zhang via B4 Relay
2025-04-24 8:32 ` [PATCH v6 0/3] Add support for Amlogic A4/A5 Reset Kelvin Zhang
2025-04-24 9:40 ` Neil Armstrong
2025-05-05 12:38 ` (subset) " Neil Armstrong
2025-05-09 15:36 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40fe47b4-9373-4afe-a5ef-1b584b3ba26f@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kelvin.zhang@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=zelong.dong@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®