From: Neil Armstrong <neil.armstrong@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>, Stephen Boyd <sboyd@kernel.org>
Cc: Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-clk@vger.kernel.org,
Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH] clk: meson: add missing MODULE_DESCRIPTION() macros
Date: Tue, 11 Jun 2024 15:46:40 +0200 [thread overview]
Message-ID: <4262a31b-0457-43b2-9773-b724e741b3e8@linaro.org> (raw)
In-Reply-To: <20240611133512.341817-1-jbrunet@baylibre.com>
On 11/06/2024 15:35, Jerome Brunet wrote:
> Add the missing MODULE_DESCRIPTION() in the Amlogic clock modules missing
> it.
>
> Reported-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Closes: https://lore.kernel.org/linux-clk/964210f1-671f-4ecc-bdb7-3cf53089c327@quicinc.com
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/meson/a1-peripherals.c | 3 ++-
> drivers/clk/meson/a1-pll.c | 3 ++-
> drivers/clk/meson/axg-aoclk.c | 3 ++-
> drivers/clk/meson/axg.c | 3 ++-
> drivers/clk/meson/c3-peripherals.c | 3 ++-
> drivers/clk/meson/c3-pll.c | 3 ++-
> drivers/clk/meson/g12a-aoclk.c | 3 ++-
> drivers/clk/meson/g12a.c | 3 ++-
> drivers/clk/meson/gxbb-aoclk.c | 2 ++
> drivers/clk/meson/gxbb.c | 3 ++-
> drivers/clk/meson/meson-aoclk.c | 2 ++
> drivers/clk/meson/meson-clkc-utils.c | 1 +
> drivers/clk/meson/meson-eeclk.c | 2 ++
> drivers/clk/meson/s4-peripherals.c | 3 ++-
> drivers/clk/meson/s4-pll.c | 3 ++-
> 15 files changed, 29 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/clk/meson/a1-peripherals.c b/drivers/clk/meson/a1-peripherals.c
> index 621af1e6e4b2..99b5bc450446 100644
> --- a/drivers/clk/meson/a1-peripherals.c
> +++ b/drivers/clk/meson/a1-peripherals.c
> @@ -2240,8 +2240,9 @@ static struct platform_driver a1_periphs_clkc_driver = {
> .of_match_table = a1_periphs_clkc_match_table,
> },
> };
> -
> module_platform_driver(a1_periphs_clkc_driver);
> +
> +MODULE_DESCRIPTION("Amlogic A1 Peripherals Clock Controller driver");
> MODULE_AUTHOR("Jian Hu <jian.hu@amlogic.com>");
> MODULE_AUTHOR("Dmitry Rokosov <ddrokosov@sberdevices.ru>");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/a1-pll.c b/drivers/clk/meson/a1-pll.c
> index 90b0aeeb049c..a16e537d139a 100644
> --- a/drivers/clk/meson/a1-pll.c
> +++ b/drivers/clk/meson/a1-pll.c
> @@ -354,8 +354,9 @@ static struct platform_driver a1_pll_clkc_driver = {
> .of_match_table = a1_pll_clkc_match_table,
> },
> };
> -
> module_platform_driver(a1_pll_clkc_driver);
> +
> +MODULE_DESCRIPTION("Amlogic S4 PLL Clock Controller driver");
> MODULE_AUTHOR("Jian Hu <jian.hu@amlogic.com>");
> MODULE_AUTHOR("Dmitry Rokosov <ddrokosov@sberdevices.ru>");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/axg-aoclk.c b/drivers/clk/meson/axg-aoclk.c
> index e4d0f46f47f5..fa1dcb7f91e4 100644
> --- a/drivers/clk/meson/axg-aoclk.c
> +++ b/drivers/clk/meson/axg-aoclk.c
> @@ -338,6 +338,7 @@ static struct platform_driver axg_aoclkc_driver = {
> .of_match_table = axg_aoclkc_match_table,
> },
> };
> -
> module_platform_driver(axg_aoclkc_driver);
> +
> +MODULE_DESCRIPTION("Amlogic AXG Always-ON Clock Controller driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c
> index 52d610110e44..065b5f198297 100644
> --- a/drivers/clk/meson/axg.c
> +++ b/drivers/clk/meson/axg.c
> @@ -2183,6 +2183,7 @@ static struct platform_driver axg_driver = {
> .of_match_table = clkc_match_table,
> },
> };
> -
> module_platform_driver(axg_driver);
> +
> +MODULE_DESCRIPTION("Amlogic AXG Main Clock Controller driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/c3-peripherals.c b/drivers/clk/meson/c3-peripherals.c
> index ff17abe6a999..56b33d23c317 100644
> --- a/drivers/clk/meson/c3-peripherals.c
> +++ b/drivers/clk/meson/c3-peripherals.c
> @@ -2359,7 +2359,8 @@ static struct platform_driver c3_peripherals_driver = {
> .of_match_table = c3_peripherals_clkc_match_table,
> },
> };
> -
> module_platform_driver(c3_peripherals_driver);
> +
> +MODULE_DESCRIPTION("Amlogic C3 Peripherals Clock Controller driver");
> MODULE_AUTHOR("Chuan Liu <chuan.liu@amlogic.com>");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/c3-pll.c b/drivers/clk/meson/c3-pll.c
> index 44b20bf4deac..6d5271c61d14 100644
> --- a/drivers/clk/meson/c3-pll.c
> +++ b/drivers/clk/meson/c3-pll.c
> @@ -740,7 +740,8 @@ static struct platform_driver c3_pll_driver = {
> .of_match_table = c3_pll_clkc_match_table,
> },
> };
> -
> module_platform_driver(c3_pll_driver);
> +
> +MODULE_DESCRIPTION("Amlogic C3 PLL Clock Controller driver");
> MODULE_AUTHOR("Chuan Liu <chuan.liu@amlogic.com>");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/g12a-aoclk.c b/drivers/clk/meson/g12a-aoclk.c
> index 58976ed8b92a..a5f4d15d8396 100644
> --- a/drivers/clk/meson/g12a-aoclk.c
> +++ b/drivers/clk/meson/g12a-aoclk.c
> @@ -473,6 +473,7 @@ static struct platform_driver g12a_aoclkc_driver = {
> .of_match_table = g12a_aoclkc_match_table,
> },
> };
> -
> module_platform_driver(g12a_aoclkc_driver);
> +
> +MODULE_DESCRIPTION("Amlogic G12A Always-ON Clock Controller driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 56e66ecc306e..4647e84d2502 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -5612,6 +5612,7 @@ static struct platform_driver g12a_driver = {
> .of_match_table = clkc_match_table,
> },
> };
> -
> module_platform_driver(g12a_driver);
> +
> +MODULE_DESCRIPTION("Amlogic G12/SM1 Main Clock Controller driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/gxbb-aoclk.c b/drivers/clk/meson/gxbb-aoclk.c
> index dbda563729db..33fafbdf65c4 100644
> --- a/drivers/clk/meson/gxbb-aoclk.c
> +++ b/drivers/clk/meson/gxbb-aoclk.c
> @@ -300,4 +300,6 @@ static struct platform_driver gxbb_aoclkc_driver = {
> },
> };
> module_platform_driver(gxbb_aoclkc_driver);
> +
> +MODULE_DESCRIPTION("Amlogic GXBB Always-ON Clock Controller driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
> index 29507b8c4304..d3175e4335bb 100644
> --- a/drivers/clk/meson/gxbb.c
> +++ b/drivers/clk/meson/gxbb.c
> @@ -3567,6 +3567,7 @@ static struct platform_driver gxbb_driver = {
> .of_match_table = clkc_match_table,
> },
> };
> -
> module_platform_driver(gxbb_driver);
> +
> +MODULE_DESCRIPTION("Amlogic GXBB Main Clock Controller driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/meson-aoclk.c b/drivers/clk/meson/meson-aoclk.c
> index b8a9d59e6726..2dd064201fae 100644
> --- a/drivers/clk/meson/meson-aoclk.c
> +++ b/drivers/clk/meson/meson-aoclk.c
> @@ -89,4 +89,6 @@ int meson_aoclkc_probe(struct platform_device *pdev)
> return devm_of_clk_add_hw_provider(dev, meson_clk_hw_get, (void *)&data->hw_clks);
> }
> EXPORT_SYMBOL_GPL(meson_aoclkc_probe);
> +
> +MODULE_DESCRIPTION("Amlogic Always-ON Clock Controller helpers");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/meson-clkc-utils.c b/drivers/clk/meson/meson-clkc-utils.c
> index 7370644e8092..4dd5948b7ae4 100644
> --- a/drivers/clk/meson/meson-clkc-utils.c
> +++ b/drivers/clk/meson/meson-clkc-utils.c
> @@ -22,4 +22,5 @@ struct clk_hw *meson_clk_hw_get(struct of_phandle_args *clkspec, void *clk_hw_da
> }
> EXPORT_SYMBOL_GPL(meson_clk_hw_get);
>
> +MODULE_DESCRIPTION("Amlogic Clock Controller Utilities");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/meson-eeclk.c b/drivers/clk/meson/meson-eeclk.c
> index 3cbc7f233bba..570992eece86 100644
> --- a/drivers/clk/meson/meson-eeclk.c
> +++ b/drivers/clk/meson/meson-eeclk.c
> @@ -58,4 +58,6 @@ int meson_eeclkc_probe(struct platform_device *pdev)
> return devm_of_clk_add_hw_provider(dev, meson_clk_hw_get, (void *)&data->hw_clks);
> }
> EXPORT_SYMBOL_GPL(meson_eeclkc_probe);
> +
> +MODULE_DESCRIPTION("Amlogic Main Clock Controller Helpers");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/s4-peripherals.c b/drivers/clk/meson/s4-peripherals.c
> index 73340c7e815e..130c50554290 100644
> --- a/drivers/clk/meson/s4-peripherals.c
> +++ b/drivers/clk/meson/s4-peripherals.c
> @@ -3809,7 +3809,8 @@ static struct platform_driver s4_driver = {
> .of_match_table = clkc_match_table,
> },
> };
> -
> module_platform_driver(s4_driver);
> +
> +MODULE_DESCRIPTION("Amlogic S4 Peripherals Clock Controller driver");
> MODULE_AUTHOR("Yu Tu <yu.tu@amlogic.com>");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/meson/s4-pll.c b/drivers/clk/meson/s4-pll.c
> index 707c107a5291..c2afade24f9f 100644
> --- a/drivers/clk/meson/s4-pll.c
> +++ b/drivers/clk/meson/s4-pll.c
> @@ -868,7 +868,8 @@ static struct platform_driver s4_driver = {
> .of_match_table = clkc_match_table,
> },
> };
> -
> module_platform_driver(s4_driver);
> +
> +MODULE_DESCRIPTION("Amlogic S4 PLL Clock Controller driver");
> MODULE_AUTHOR("Yu Tu <yu.tu@amlogic.com>");
> MODULE_LICENSE("GPL");
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-06-11 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 13:35 Jerome Brunet
2024-06-11 13:46 ` Neil Armstrong [this message]
2024-06-14 8:58 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4262a31b-0457-43b2-9773-b724e741b3e8@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®