From: Neil Armstrong <narmstrong@baylibre.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH 35/52] drm/meson: Drop explicit drm_mode_config_cleanup call
Date: Wed, 19 Feb 2020 11:39:03 +0100 [thread overview]
Message-ID: <43d8fdec-5ea5-1288-e886-0e608f6dd7b4@baylibre.com> (raw)
In-Reply-To: <20200219102122.1607365-36-daniel.vetter@ffwll.ch>
On 19/02/2020 11:21, Daniel Vetter wrote:
> It's right above the drm_dev_put().
>
> Aside: This driver gets its devm_ stuff all wrong wrt drm_device and
> anything hanging off that. Not the only one unfortunately.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: linux-amlogic@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/gpu/drm/meson/meson_drv.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index b5f5eb7b4bb9..ae94d14ab7bc 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -284,7 +284,9 @@ static int meson_drv_bind_master(struct device *dev, bool has_components)
> /* Remove early framebuffers (ie. simplefb) */
> meson_remove_framebuffers();
>
> - drm_mode_config_init(drm);
> + ret = drm_mode_config_init(drm);
> + if (ret)
> + goto free_drm;
> drm->mode_config.max_width = 3840;
> drm->mode_config.max_height = 2160;
> drm->mode_config.funcs = &meson_mode_config_funcs;
> @@ -379,7 +381,6 @@ static void meson_drv_unbind(struct device *dev)
> drm_dev_unregister(drm);
> drm_irq_uninstall(drm);
> drm_kms_helper_poll_fini(drm);
> - drm_mode_config_cleanup(drm);
> drm_dev_put(drm);
> }
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-02-19 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200219102122.1607365-1-daniel.vetter@ffwll.ch>
2020-02-19 10:21 ` Daniel Vetter
2020-02-19 10:39 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43d8fdec-5ea5-1288-e886-0e608f6dd7b4@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®