mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: marcel@holtmann.org (Marcel Holtmann)
To: linus-amlogic@lists.infradead.org
Subject: [RFC v2 1/9] serdev: implement parity configuration
Date: Tue, 2 Jan 2018 12:16:41 +0100	[thread overview]
Message-ID: <4FDCB65A-641A-4134-BAF1-4A777012FDE7@holtmann.org> (raw)
In-Reply-To: <20180101204217.26165-2-martin.blumenstingl@googlemail.com>

Hi Martin,

> Some Bluetooth modules (for example the ones found in Realtek RTL8723BS
> and RTL8723DS) want to communicate with the host with even parity
> enabled.
> Add a new function and the corresponding internal callbacks so parity
> can be configured. This supports enabling and disabling parity as well
> as setting the type to odd or even.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/tty/serdev/core.c           | 12 ++++++++++++
> drivers/tty/serdev/serdev-ttyport.c | 21 +++++++++++++++++++++
> include/linux/serdev.h              |  5 +++++
> 3 files changed, 38 insertions(+)
> 
> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> index 1bef39828ca7..d327b02980f5 100644
> --- a/drivers/tty/serdev/core.c
> +++ b/drivers/tty/serdev/core.c
> @@ -225,6 +225,18 @@ void serdev_device_set_flow_control(struct serdev_device *serdev, bool enable)
> }
> EXPORT_SYMBOL_GPL(serdev_device_set_flow_control);
> 
> +void serdev_device_set_parity(struct serdev_device *serdev, bool enable,
> +			      bool odd)
> +{
> +	struct serdev_controller *ctrl = serdev->ctrl;
> +
> +	if (!ctrl || !ctrl->ops->set_parity)
> +		return;
> +
> +	ctrl->ops->set_parity(ctrl, enable, odd);
> +}
> +EXPORT_SYMBOL_GPL(serdev_device_set_parity);
> +

this really needs Rob?s ACK before I take the patch.

Regards

Marcel

  reply	other threads:[~2018-01-02 11:16 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-01 20:42 [RFC v2 0/9] Realtek Bluetooth serdev support (H5 protocol) Martin Blumenstingl
2018-01-01 20:42 ` [RFC v2 1/9] serdev: implement parity configuration Martin Blumenstingl
2018-01-02 11:16   ` Marcel Holtmann [this message]
2018-01-02 21:16     ` Martin Blumenstingl
2018-01-02 21:34       ` Martin Blumenstingl
2018-01-03  9:06         ` Johan Hovold
2018-01-03 12:37         ` Marcel Holtmann
2018-01-01 20:42 ` [RFC v2 2/9] dt-bindings: net: bluetooth: add support for Realtek Bluetooth chips Martin Blumenstingl
2018-01-02 11:16   ` Marcel Holtmann
2018-01-02 21:10     ` Martin Blumenstingl
2018-01-03 19:07       ` Rob Herring
2018-01-01 20:42 ` [RFC v2 3/9] Bluetooth: btrtl: add MODULE_FIRMWARE declarations Martin Blumenstingl
2018-01-01 20:42 ` [RFC v2 4/9] Bluetooth: btrtl: split the device initialization into smaller parts Martin Blumenstingl
2018-01-01 20:42 ` [RFC v2 5/9] Bluetooth: btrtl: add support for retrieving the UART settings Martin Blumenstingl
2018-01-01 20:42 ` [RFC v2 6/9] Bluetooth: btrtl: add support for the RTL8723BS and RTL8723DS chips Martin Blumenstingl
2018-01-01 20:42 ` [RFC v2 7/9] bluetooth: btrtl: load the config blob from devicetree when available Martin Blumenstingl
2018-01-02 11:11   ` Marcel Holtmann
2018-01-02 11:15     ` Carlo Caione
2018-01-02 11:19       ` Marcel Holtmann
2018-01-02 11:31         ` Carlo Caione
2018-01-02 11:38           ` Marcel Holtmann
2018-01-02 21:43             ` Martin Blumenstingl
2018-01-02 21:46           ` Martin Blumenstingl
2018-01-02 23:06             ` Carlo Caione
2018-01-03 20:50               ` Martin Blumenstingl
2018-01-04  9:46                 ` Carlo Caione
2018-01-05 14:57                   ` Marcel Holtmann
2018-01-05 16:15                     ` Marcel Holtmann
2018-01-05 20:44                       ` Marcel Holtmann
2018-01-07 20:07                         ` Martin Blumenstingl
2018-01-09 15:26                           ` Marcel Holtmann
2018-01-01 20:42 ` [RFC v2 8/9] Bluetooth: drop HCI_UART_INIT_PENDING support Martin Blumenstingl
2018-01-02 11:04   ` Marcel Holtmann
2018-01-02 21:06     ` Martin Blumenstingl
2018-01-03 17:14       ` Loic Poulain
2018-01-03 20:30         ` Martin Blumenstingl
2018-01-03 18:38   ` Rob Herring
2018-01-03 20:38     ` Martin Blumenstingl
2018-01-01 20:42 ` [RFC v2 9/9] Bluetooth: hci_h5: add support for Realtek UART Bluetooth modules Martin Blumenstingl
2018-01-02 11:11   ` Marcel Holtmann
2018-01-02 21:27     ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FDCB65A-641A-4134-BAF1-4A777012FDE7@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®