mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Yu Tu <yu.tu@amlogic.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: <linux-serial@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Vyacheslav <adeep@lexina.in>, Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH V3 6/6] tty: serial: meson: Change request_irq to devm_request_irq and move devm_request_irq to meson_uart_probe()
Date: Fri, 31 Dec 2021 18:37:42 +0800	[thread overview]
Message-ID: <50127eb4-dfa0-6b80-36c0-8c246eb4d164@amlogic.com> (raw)
In-Reply-To: <CAFBinCAzDSw6jmpU-S2KGZ32D+U1fNqLgKMmkPSdz=-XN4isDA@mail.gmail.com>



On 2021/12/31 6:41, Martin Blumenstingl wrote:
> [ EXTERNAL EMAIL ]
> 
> On Thu, Dec 30, 2021 at 11:22 AM Yu Tu <yu.tu@amlogic.com> wrote:
>>
>> Because an interrupt error occurs when the user opens /dev/ttyAML* but
>> don't close it, and then opens the same port again. This problem is
>> encountered in actual projects.
> I would like to hear from the serial driver maintainers whether the
> described problem is a userspace or driver bug.
> 
> If it's a driver bug then this should be sent as a separate patch
> (unrelated to this series) with a fixes tag.
> 
> [...]
>> +       ret = devm_request_irq(&pdev->dev, port->irq, meson_uart_interrupt,
>> +                              0, dev_name(&pdev->dev), port);
> You can replace dev_name(&pdev->dev) with NULL to achieve the same
> result with less code.
> dev_name(dev) is the default value, see [0]
> 
I think you are right, I will remove this patch. I learned a lot.
> 
> Best regards,
> Martin
> 
> 
> [0] https://elixir.bootlin.com/linux/v5.15/source/kernel/irq/devres.c#L64
> 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

      reply	other threads:[~2021-12-31 10:38 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-30 10:21 [PATCH V3 0/6] the UART driver compatible with the Amlogic Meson Yu Tu
2021-12-30 10:21 ` [PATCH V3 1/6] tty: serial: meson: Drop the legacy compatible strings and clock code Yu Tu
2021-12-30 22:22   ` Martin Blumenstingl
2021-12-31 10:27     ` Yu Tu
2021-12-31 15:35       ` Martin Blumenstingl
2022-01-03 14:59         ` Neil Armstrong
2022-01-03 15:19           ` Greg Kroah-Hartman
2022-01-03 15:29             ` Neil Armstrong
2022-01-03 16:29               ` Greg Kroah-Hartman
2022-01-03 16:35                 ` Neil Armstrong
2021-12-30 10:21 ` [PATCH V3 2/6] tty: serial: meson: Request the register region in meson_uart_probe() Yu Tu
2021-12-30 12:29   ` Greg Kroah-Hartman
2021-12-30 22:28     ` Martin Blumenstingl
2021-12-30 10:21 ` [PATCH V3 3/6] dt-bindings: serial: meson: Support S4 SoC uart. Also Drop compatible = amlogic, meson-gx-uart Yu Tu
2021-12-30 12:28   ` [PATCH V3 3/6] dt-bindings: serial: meson: Support S4 SoC uart. Also Drop compatible = amlogic,meson-gx-uart Greg Kroah-Hartman
2021-12-31 10:18     ` Yu Tu
2021-12-30 22:34   ` Martin Blumenstingl
2021-12-31 10:35     ` Yu Tu
2021-12-30 10:21 ` [PATCH V3 4/6] tty: serial: meson: The UART baud rate calculation is described using the common clock code. Also added S4 chip uart Compatible Yu Tu
2021-12-30 12:27   ` Greg Kroah-Hartman
2021-12-31 10:23     ` Yu Tu
2021-12-30 23:13   ` Martin Blumenstingl
2021-12-31 11:24     ` Yu Tu
2021-12-31 15:32       ` Martin Blumenstingl
2022-01-01 13:30         ` Yu Tu
2022-01-02 19:36           ` Martin Blumenstingl
2022-01-04  8:20             ` Yu Tu
2022-01-03 13:50           ` Jerome Brunet
2022-01-03 12:40   ` Jerome Brunet
2022-01-04  9:57     ` Yu Tu
2022-01-04 10:36       ` Jerome Brunet
2022-01-04 14:35         ` Yu Tu
2022-01-05  5:53           ` Yu Tu
2021-12-30 10:21 ` [PATCH V3 5/6] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit Yu Tu
2021-12-30 22:44   ` Martin Blumenstingl
2021-12-31 10:42     ` Yu Tu
2021-12-30 10:21 ` [PATCH V3 6/6] tty: serial: meson: Change request_irq to devm_request_irq and move devm_request_irq to meson_uart_probe() Yu Tu
2021-12-30 22:41   ` Martin Blumenstingl
2021-12-31 10:37     ` Yu Tu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50127eb4-dfa0-6b80-36c0-8c246eb4d164@amlogic.com \
    --to=yu.tu@amlogic.com \
    --cc=adeep@lexina.in \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbrunet@baylibre.com \
    --cc=jirislaby@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®