From: Neil Armstrong <narmstrong@baylibre.com>
To: Otto Meier <gf435@gmx.net>, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] pinctrl: meson: add tsin pinctrl for meson gxbb/gxl/gxm
Date: Tue, 3 Mar 2020 15:05:56 +0100 [thread overview]
Message-ID: <51cb10de-ead9-49d5-8623-9c2e55f38635@baylibre.com> (raw)
In-Reply-To: <0522f4cb-936d-50e0-1b6f-c885c94d7aa9@gmx.net>
On 03/03/2020 14:23, Otto Meier wrote:
> Hello
>
> after having fixed the uart_c pinctrl definitions during September,
>
> this patch would revert part of the formerly Patch.
>
>
> /* Bank Y */
> - GROUP(uart_cts_c, 1, 17),
> - GROUP(uart_rts_c, 1, 16),
> - GROUP(uart_tx_c, 1, 19),
> - GROUP(uart_rx_c, 1, 18),
> + GROUP(tsin_a_fail, 3, 3),
> + GROUP(tsin_a_d_valid, 3, 2),
> + GROUP(tsin_a_sop, 3, 1),
> + GROUP(tsin_a_clk, 3, 0),
> + GROUP(tsin_a_d0, 3, 4),
> + GROUP(tsin_a_dp, 3, 5),
> + GROUP(uart_cts_c, 1, 19),
> + GROUP(uart_rts_c, 1, 18),
> + GROUP(uart_tx_c, 1, 17),
> + GROUP(uart_rx_c, 1, 16),
>
> The Numbering of uart_C pins is changed by this patch.
Indeed, Thanks for noticing !
>
> This patch definitly breaks the sdcard, if uart_c is enabled.
Nop it only shuffles the uartc rx/tc and rtc/cts pins register bits,
it would still work if tr/rx/rts/cts was used alltogether.
But it's still wrong and the patch should be fixed.
Neil
>
> bye
>
> Otto
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-03-03 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 13:23 Otto Meier
2020-03-03 14:05 ` Neil Armstrong [this message]
2020-03-04 9:27 ` Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2020-03-02 4:40 Christian Hewitt
2020-03-03 12:40 ` Linus Walleij
2020-03-04 10:03 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51cb10de-ead9-49d5-8623-9c2e55f38635@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=gf435@gmx.net \
--cc=linux-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®