mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Christian Hewitt <christianshewitt@gmail.com>
To: Tim Lewis <elatllat@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	joy.cho@hardkernel.com, Neil Armstrong <narmstrong@baylibre.com>,
	khilman@baylibre.com, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, tobetter@gmail.com,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [v2] arm64: dts: meson: odroid-n2: extend cpu opp-points
Date: Wed, 22 Apr 2020 18:54:21 +0400	[thread overview]
Message-ID: <52230ECA-EA47-499D-B71C-FFCD374B75C3@gmail.com> (raw)
In-Reply-To: <20200418214223.GA4484@imac>


> On 19 Apr 2020, at 1:42 am, Tim Lewis <elatllat@gmail.com> wrote:
> 
> Odroid N2 has a large heatsink and HardKernel supports overclock
> through the addition to extra opp points in their official kernel
> sources [1]. Add these to the N2 dts only, as other S922X devices
> may not have suitable heatsinks.
> 
> [1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f
> Signed-off-by: Tim Lewis <elatllat@gmail.com>

Kodi is not a demanding workload, but the extra opp points are being used:

N2:~ # cat /sys/devices/system/cpu/cpufreq/policy0/stats/trans_table 
   From  :    To
         :    100000    250000    500000    667000   1000000   1200000   1398000   1512000   1608000   1704000   1896000   1992000 
   100000:         0     20465       294        81        47         0         1         0         0         0         0       183 
   250000:     20388         0       161        52        59         0         0         0         1         0         1       169 
   500000:       199       256         0         9        47         1         2         0         0         0         0        57 
   667000:       177        50        10         0       284         1         1         0         0         0         0       136 
  1000000:       230        12        15       284         0         1         2         0         0         0         0       285 
  1200000:         0         0         0         1         0         0         0         0         0         1         0         2 
  1398000:         1         1         0         2         0         0         0         0         1         1         0         3 
  1512000:         0         0         0         0         0         0         0         0         0         1         0         2 
  1608000:         0         0         0         0         0         0         0         1         0         0         0         2 
  1704000:         0         1         0         0         0         0         1         0         0         0         0         2 
  1896000:         0         0         1         0         0         0         0         0         0         0         0         1 
  1992000:        76        47        90       230       392         0         2         2         1         1         1         0 

N2:~ # cat /sys/devices/system/cpu/cpufreq/policy2/stats/trans_table 
   From  :    To
         :    100000    250000    500000    667000   1000000   1200000   1398000   1512000   1608000   1704000   1800000   1908000 
   100000:         0      1698       130        76        87         0         0         0         1         0         1       199 
   250000:      1655         0        25        15       357         1         2         0         1         0         0        12 
   500000:       258        54         0     50102        30         3         1         0         0         0         1        32 
   667000:       267       151     49708         0        77         3         0         0         0         0         0        11 
  1000000:         3         5       525        15         0         3         2         0         1         1         0         6 
  1200000:         0         2         1         2         2         0         3         0         0         0         1         4 
  1398000:         1         0         1         1         4         0         0         1         1         0         2         2 
  1512000:         0         0         0         0         0         0         1         0         0         0         0         1 
  1608000:         1         0         0         1         0         1         0         0         0         0         0         3 
  1704000:         0         0         0         0         0         1         0         1         0         0         0         1 
  1800000:         0         0         1         1         0         0         1         0         1         0         0         1 
  1908000:         8       158        90         4         3         3         3         0         1         2         0         0 

Board boots in under 4 seconds, Kodi home-screen in about 7 seconds. I haven’t seen the N2 rise over 44ºC.

I’ve also tested some S922X box devices (moving the change to meson-g12b-s922x.dtsi) and no obvious issues.

Tested-by: Christian Hewitt <christianshewitt@gmail.com>

> ---
> .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index 42f154057..6f32ac83f 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -260,6 +260,25 @@
> 			};
> 		};
> 	};
> +
> +	cpu_opp_table_0: opp-table-0 {
> +		opp-1992000000 {
> +			opp-hz = /bits/ 64 <1992000000>;
> +			opp-microvolt = <1001000>;
> +		};
> +	};
> +
> +	cpub_opp_table_1: opp-table-1 {
> +		opp-1800000000 {
> +			opp-hz = /bits/ 64 <1800000000>;
> +			opp-microvolt = <981000>;
> +		};
> +
> +		opp-1908000000 {
> +			opp-hz = /bits/ 64 <1908000000>;
> +			opp-microvolt = <1022000>;
> +		};
> +	};
> };
> 
> &arb {
> -- 
> 2.17.1
> 


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2020-04-22 14:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-18 21:42 Tim Lewis
2020-04-22 14:54 ` Christian Hewitt [this message]
2020-04-22 15:08   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52230ECA-EA47-499D-B71C-FFCD374B75C3@gmail.com \
    --to=christianshewitt@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=elatllat@gmail.com \
    --cc=joy.cho@hardkernel.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=tobetter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®