From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87CDAC4829A for ; Tue, 13 Feb 2024 15:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YYfjXfL/bQ3HxF49nwa0KJxwK4Ys30gRbNpYnO8O3+c=; b=LLL67QPhNPWypw lmnVCV3ivAIbBaTjn5m+ktSKOTYvDVuaKVklmdEvwACS61YfabUz+Dx9RF699VrMw20SZzkbGC5Xj fMLDjptqfDrifIpCjYLW7sbDY4x2asMKYXV3DYDzXYGG4abTO0Zlzg7+IX4Leq6xGH0/nswXsoBP1 wHAjzmFfdwq8zs7y6itxbAHtrLVUvPd9QtmGUbGcqgwTslStH5zxC/+gIV6OKhXPrQG7j0Q2ObOz+ JiiYIbBM9Bw0h54kGff6QBLpoElOMwdfQyPyTQzWA5ByqNjicgTGDlNEY7l1qc9Pne6I1xPgnXM/C OpZQYRHBv+KD1O0jdFsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZuGZ-00000009dm3-3Aaa; Tue, 13 Feb 2024 15:00:11 +0000 Received: from wfhigh2-smtp.messagingengine.com ([64.147.123.153]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZuGX-00000009dko-0uY2; Tue, 13 Feb 2024 15:00:10 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.west.internal (Postfix) with ESMTP id C02C118000A2; Tue, 13 Feb 2024 10:00:02 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 13 Feb 2024 10:00:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1707836402; x=1707922802; bh=mlH1+joGCi tNuHIq4NgYcD03PcGWwGsVclCAlzSrC6g=; b=rr9W2xZSRfUYXJ1K7Er8kmSzdr YPeVZLRDo6na4KI7s6Y318wy1IvOOGMs1THUmpkm21w2WCSEUmC+Chh3StFa07Qv rzXFAC5qVpLw9Mshgct0qFN/zt7LuKANbNJ0tGGHSCiAEmx5NdQSO0hzEpkBtRJN HUO1aDpNc4CnRpq6BPyXwTlW9G+bWMkj4FnQwv6LpizCOSjdzI1WBwgW49J4ZP/Y I0gZHBBKNC129t7BmBIzYT4sF5no8DEUiH5Iz6/PbmRaVJT8/lTyRbSymjLVlJob DJbPwgh+2m0ltbI468PxpuFzzBVPimmGePa+2TremYQfBKJ9pcRnVLYOEOfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707836402; x=1707922802; bh=mlH1+joGCitNuHIq4NgYcD03PcGW wGsVclCAlzSrC6g=; b=qrlQe9hiFEDFUkxfTxKpqQXl1A2Bq8hi2c/1LQL2jgry F5rWnTb6GhLifUWVur74iuEDk8GglPoeczz8klOKnphJEBFhxBxyj7YglEbtiZV7 AP3glPNibTQvL4K6Ti9KnxQBWT6Vum/2GZpRmaavP0yDET4aXiZE0fHvKyHN1YzC YUmuMOyUAJVEdZV1a+Z/eGVBq/j+0pjU5R/p2U8wYv63Mu0SiZ+LeUlqGxy8mp3E PE8Ha+l2Gl9zBhylnYu02tvQVe2vdQoyaUJBFLQ7Zg7kLPgdcDulF9jtyms9Sckv 9iMF+lqcxL+6fscH5907nH4SdJUg0eSLCU3wYEmfEQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehgdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 28D58B6008D; Tue, 13 Feb 2024 10:00:02 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61 MIME-Version: 1.0 Message-Id: <5448aaaa-3784-49c5-bc42-c5cd1e953949@app.fastmail.com> In-Reply-To: <20240213142831.3069049-1-jbrunet@baylibre.com> References: <20240213142831.3069049-1-jbrunet@baylibre.com> Date: Tue, 13 Feb 2024 15:59:39 +0100 From: "Arnd Bergmann" To: "Jerome Brunet" , "Srinivas Kandagatla" Cc: "Neil Armstrong" , "Kevin Hilman" , "Martin Blumenstingl" , "Nathan Chancellor" , "Nick Desaulniers" , "Bill Wendling" , "Justin Stitt" , "Jernej Skrabec" , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v2] nvmem: meson-efuse: fix function pointer type mismatch X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_070009_304265_94A67FAB X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Feb 13, 2024, at 15:28, Jerome Brunet wrote: > clang-16 warns about casting functions to incompatible types, as is done > here to call clk_disable_unprepare: > > drivers/nvmem/meson-efuse.c:78:12: error: cast from 'void (*)(struct > clk *)' to 'void (*)(void *)' converts to incompatible function type > [-Werror,-Wcast-function-type-strict] > 78 | (void(*)(void > *))clk_disable_unprepare, > > The pattern of getting, enabling and setting a disable callback for a > clock can be replaced with devm_clk_get_enabled(), which also fixes > this warning. > > Fixes: 611fbca1c861 ("nvmem: meson-efuse: add peripheral clock") > Reported-by: Arnd Bergmann > Signed-off-by: Jerome Brunet Perfect, much nicer than my version. Acked-by: Arnd Bergmann _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic