From: Neil Armstrong <narmstrong@baylibre.com>
To: Furkan Kardame <f.kardame@manjaro.org>
Cc: khilman@baylibre.com, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v4] arm64: dts: meson: add gpio-fan control to GS-King-X
Date: Mon, 13 Jun 2022 10:18:47 +0200 [thread overview]
Message-ID: <56c95eb4-5406-3864-f4ec-0d5c3f71e9cf@baylibre.com> (raw)
In-Reply-To: <20220611170852.19487-1-f.kardame@manjaro.org>
On 11/06/2022 19:08, Furkan Kardame wrote:
> GS-King-X has a single speed GPIO fan which is always-on by default.
> If we add controls for the fan and a trip point,
> the fan stays off most of the time, reducing background
> noise from the unit.
>
> Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>
> ---
> Changelog:
> V1:
> * Using tabs instead of space.
>
> V2:
> * Remove unused map.
>
> V3:
> * Fixed speed-map indentation
> * Aligned brackets
> * Changed cooling-device
> * Increased temperature to 70°C
>
> V4:
> * Fixed syntax error.
> .../boot/dts/amlogic/meson-g12b-gsking-x.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> index 6c7bfacba..23592ae21 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> @@ -20,6 +20,14 @@ aliases {
> rtc1 = &vrtc;
> };
>
> + gpio_fan: gpio-fan {
> + compatible = "gpio-fan";
> + gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
> + /* Using Dummy Speed */
> + gpio-fan,speed-map = <0 0>, <1 1>;
> + #cooling-cells = <2>;
> + };
> +
> gpio-keys-polled {
> compatible = "gpio-keys-polled";
> #address-cells = <1>;
> @@ -96,6 +104,23 @@ &clkc_audio {
> status = "okay";
> };
>
> +&cpu_thermal {
> + trips {
> + cpu_active: cpu-active {
> + temperature = <70000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "active";
> + };
> + };
> +
> + cooling-maps {
> + map {
> + trip = <&cpu_active>;
> + cooling-device = <&gpio_fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> +};
> +
> &frddr_a {
> status = "okay";
> };
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-06-13 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 17:08 Furkan Kardame
2022-06-13 8:18 ` Neil Armstrong [this message]
2022-06-13 8:19 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56c95eb4-5406-3864-f4ec-0d5c3f71e9cf@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=f.kardame@manjaro.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®