From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB323C4345F for ; Fri, 12 Apr 2024 17:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l0R+CvJyAfWI2khLLGTixp2wcsqsbuJBz5aOC8E/VIs=; b=WrHJIKdo1Am1zt V6c8du9yXXUshDWtF+F8/cP42814sbjIUEQNKjUB8uzzs+RfZzfezJCd7HFjGAhEyXo2hVNvSHKRt duWWVbF0OMMOCzNpPv7m2gpeZvQ6jmP8tuzr7rjODlZqBMMQSocSdDho5a1pL2wH3Rj+rlWGon2kI q+rsOPpH3mOMbaRdTG1OfR9PKvgzq91NVMmKOzEfSmillbnWTIzPe7DGLLjdIV3siBjXaWE3We/Bi 88ORmI5QADM0CoCtXwFFue6bgLc+BoT54rAetPPqiuhMCE7umZMCbnL6bhvpH/mlu4QAT8Q0Dcf4S xAYLM0V6+1g+BPMaJTtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvL9d-00000000l8C-3czf; Fri, 12 Apr 2024 17:57:37 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvL9a-00000000l3j-1br1 for linux-amlogic@lists.infradead.org; Fri, 12 Apr 2024 17:57:36 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-518a56cdbceso8289e87.0 for ; Fri, 12 Apr 2024 10:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712944646; x=1713549446; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=4x6CO2roFzlygK8ZkH3v2xYQJthxJprOn/AYJNBa9HE=; b=iocn1JDpjoIRzbXt6GpTYA3NgSGEmcIKWjXKRt7c4KS7icEUQhqAzVIfCK5ARLblka qA0t62ovfp0+SMe/ytpGdKK6P1bfIWD48tZBWiRFixKpixqypKC0gDOWfhjQVs0PzDCi n8fEDk3Zd6VDW4bFRW0Cb2rluOCI8Qlm5wqjVSOOBTrXa0JP/Z/wklqUoVPFzti2sfNN 9u3cZqxtM5jc6S2PcLZB+QmQjZQdKyIPh+Ru9ysIvXW9HUJ5U06GSRb/1Yr8ra7InzYy +2x9zqobBsjcVUrXqhKS2f4tU0+/qEEr1ShdFmEi2ied4zayWXEB5OHVdBv/nCDEHJUs GH+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712944646; x=1713549446; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4x6CO2roFzlygK8ZkH3v2xYQJthxJprOn/AYJNBa9HE=; b=r1TQhr7+8kK0SVd/MOlywuyyQ5KQFR8ThzdNfTUN8KBDyt7FHvOJxWGzIJ+nsE9NEx DTCf/xMrAIHb2xyFelcKKTRiF6T4w9uvAcyqz/iy/V+T5hsGwfgmVdAq4cSWA5mw00jH DRmJ0YdO2+ytFIlrYxN6OzZoPsONxyEN+aJXIPbZTe+ma2Q2ztHhwThon/WXWJPXJun1 eZ8LnksxkWnV1Zu0tK1Dhc9NIwgZNPQVc7WU9k3I6d7RBoDgnq9MoZ+tWVi+FLxCiOiJ 9ILLO5qJi7ks2pGcI3L85dF7tFHmSpo1x0bkudA6v4d2/5T3WsJUMrsNb0uqY5YJb9Js X2LA== X-Forwarded-Encrypted: i=1; AJvYcCWu828R2KJc5uBslO2LMHGt3RuyyvaSFDUZPHqg8yEqiQ2sFiZclqlzzv+6d8sBZiO9V2D+pI19j0ulbPhndR/dyOZzC2oI+6ErWuS/4rpVB/k= X-Gm-Message-State: AOJu0Yy8PcVUzB+LqNzICAyUqsXONw5wdjlS5ZTNEvbkGrwV8T4bJHqQ o9DUQlYpWvxX8zyMfah1SQCkasiHrCNSx3JoMLTKvHt3qBP0w2Modin4cVq3jjs= X-Google-Smtp-Source: AGHT+IFUzNnjE4vp9FT/3YZwaF/+YBDJmtBRgmP5Mk3dry+LJrwp3YCYOIZWkivM15e9EC3TZeSY6g== X-Received: by 2002:a19:430f:0:b0:518:86a8:5a33 with SMTP id q15-20020a19430f000000b0051886a85a33mr1507643lfa.56.1712944645997; Fri, 12 Apr 2024 10:57:25 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id bq13-20020a170906d0cd00b00a52307b3aa9sm1158361ejb.57.2024.04.12.10.57.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Apr 2024 10:57:25 -0700 (PDT) Message-ID: <579a1569-7bba-491f-ba5e-7cfcb34ccc1f@linaro.org> Date: Fri, 12 Apr 2024 19:57:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: reset: Add Amlogic T7 Reset Controller To: neil.armstrong@linaro.org, kelvin.zhang@amlogic.com, Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Zelong Dong References: <20240329-t7-reset-v1-0-4c6e2e68359e@amlogic.com> <20240329-t7-reset-v1-1-4c6e2e68359e@amlogic.com> <927ad2cb-3b41-4eda-b930-856be64ae9ba@linaro.org> <10650c59-96f2-4234-b5fd-aa8efec90e5b@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <10650c59-96f2-4234-b5fd-aa8efec90e5b@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_105734_505982_EEF7DDB1 X-CRM114-Status: GOOD ( 21.86 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 12/04/2024 15:12, Neil Armstrong wrote: > Hi, > > On 29/03/2024 20:39, Krzysztof Kozlowski wrote: >> On 29/03/2024 10:17, Kelvin Zhang via B4 Relay wrote: >>> From: Zelong Dong >>> >>> Add a new compatible and the related header file >>> for Amlogic T7 Reset Controller. >>> >>> Signed-off-by: Zelong Dong >>> Signed-off-by: Kelvin Zhang >>> --- >>> .../bindings/reset/amlogic,meson-reset.yaml | 1 + >>> include/dt-bindings/reset/amlogic,t7-reset.h | 197 +++++++++++++++++++++ >>> 2 files changed, 198 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml >>> index f0c6c0df0ce3..fefe343e5afe 100644 >>> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml >>> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml >>> @@ -19,6 +19,7 @@ properties: >>> - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs >>> - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs >>> - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs >>> + - amlogic,t7-reset # Reset Controller on T7 and compatible SoCs >>> >> >> If there is going to be any resend, please drop the comment. It's not >> really helpful and makes it trickier to read. >> >>> reg: >>> maxItems: 1 >>> diff --git a/include/dt-bindings/reset/amlogic,t7-reset.h b/include/dt-bindings/reset/amlogic,t7-reset.h >>> new file mode 100644 >>> index 000000000000..ca4a832eeeec >>> --- /dev/null >>> +++ b/include/dt-bindings/reset/amlogic,t7-reset.h >>> @@ -0,0 +1,197 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */ >>> +/* >>> + * Copyright (c) 2024 Amlogic, Inc. All rights reserved. >>> + */ >>> + >>> +#ifndef _DT_BINDINGS_AMLOGIC_T7_RESET_H >>> +#define _DT_BINDINGS_AMLOGIC_T7_RESET_H >>> + >>> +/* RESET0 */ >>> +/* 0-3 */ >> >> I assume this matches existing drivers which do not use IDs but map the >> binding to hardware value? I remember we talked about changing it, so if >> something happened about this and it could be changed: please change. > > I'm not aware of such discussion, and I don't really see the issue... > thoses are IDs, and yes they match the Hardware offsets, and ? Bindings are not for hardware offsets/values/addresses. It's just not a binding. I quickly looked at your driver patch and it confirms: not a binding. Binding constant is used by the driver and DTS consumer. I am really sure we had this talk in the past, but could be I think about different platform. Since this is not a binding, I do not think claiming there is any ABI here is reasonable. Feel free to store them with other hardware values, like in DTS headers etc. We already moved to DTS headers several such "non-binding" constants. Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic