From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E6EDD30000 for ; Fri, 18 Oct 2024 12:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gZCO5ZUSOqoB2KPGeodKIcoEGWgGEGp6DN6og3JdbC8=; b=Ffiirip4jrub6d2GDjBrnytbAH JNRYinAPncX4GxhYxEFtEDoYhkvGqaNr9U15UAdwNQ3azUvplPjsDKtoO4YmghfaeUYp8c/IHbHMZ e5VANXHW+dw1u7NEelS8fH53ioZr4huTLC0/kWXKbzoEUz2BKTrYvdzDQeu+4kSgXrID7OhCdZruw 64zEKmzpMXJBzJHP/RkBzvx10VeKG9OHTRI2rFpwBQjzvv0gp5SESdpJ+2fTH1uSiPsrapz43QDR4 6lJYDZb2mp8+fQx1La3FlIBknUt8ZlBgH35NahWzWxX4eHD2ZPeP/YowE6NdL4fSc32QTI7cDLMWV WHC5UgCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1mBY-00000000lSX-1Rdt; Fri, 18 Oct 2024 12:34:28 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1m99-00000000l79-33ip for linux-amlogic@lists.infradead.org; Fri, 18 Oct 2024 12:32:02 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4311c285bc9so20365075e9.3 for ; Fri, 18 Oct 2024 05:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729254717; x=1729859517; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=WQ57lSjaC9RAyZl1NHQTI6Ado2aNaJuw86YmjLl6fxI=; b=o87Um3oFdlEjsN++3Wh/gGWWSEKzaM6gPh90KroyosQiw/gNCQZAR8G1FhQnnZDf5S 4uG/KOrx4mz1RBeaGbVqJRvyYgQBJB/TGeQWTE32mTYensR4Kavyimd5x1HuS7DYCFPE YcOC+d8GEPWWaBleuCQlM2wJTbDzjM6BmglLcjrPOkC4yP5/K0g2b0fAKD8MiDHD9yrI auIqp70yHMSlnsWp/nu9mVCLD5KuSmPaZ4YRXbEWQC67+wp3ZW9zjugX0TRwfp+7S38R gs+QCYNww+mhEQS6/O1Z5thqzHueaRvHVuzeeAd/P2D7E+X7zKG4Sa4b2M+6SzMkt+EZ k7rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729254717; x=1729859517; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WQ57lSjaC9RAyZl1NHQTI6Ado2aNaJuw86YmjLl6fxI=; b=dHvLyBvQV856CUks5Ud9wn3m1o/vQUNHxg850DaolYsgMPnAPwRbhke+OPhEnONU8J nCY7So9a5//xz7DCglkj6VRwnoYpfS4Xa0NdNv0mtFDpFIbOzk+MNpXcq+/h7p8yunaq ihvA9vzbGPAk3+rSutLgYvyKyfjboPeKyebG0qwPrdndNohm3Ni4OcSnGJydJXY2fofT V2OAuMNWsCWeKAa447Bg3bntaPieccsFKTgohasIA6SXInaPW6/t6sonvFskR866D4Hd QNS/9Ru/MTdcaaIZ+jN+347+Nk2DiNfo9RSf9RSQCdTmRTNGZXKnSezuLpR3+Ne8gCB1 fSaw== X-Forwarded-Encrypted: i=1; AJvYcCU7oTFwv7Rf/En5AOYIJXsYa0zuV2cD5ozcYhvaxHu8C4hIgEJ6VZofFdjcNvYpWBZjOsbWepRxjVbJsICc@lists.infradead.org X-Gm-Message-State: AOJu0Yzix+RNnuy3SLxboeFfzHkW5gU4eGfSGzFHBd/ap1/7+8dPw6+L 7gPqX8o0WaHCTwQ9KIoBZtP7aCfC+LFPI55ahM8JKNRZA8gSPyI/Y42Na7B7aDU= X-Google-Smtp-Source: AGHT+IEUdRrlAq3WPxfqkG3BlZjmDH+ScLOh0LICFKDXfeE0jKHxiu7vIWXS+8hii+rHrVL6AW9mkQ== X-Received: by 2002:a05:600c:c8a:b0:431:2b66:44f7 with SMTP id 5b1f17b1804b1-4316169737dmr17180495e9.31.1729254717395; Fri, 18 Oct 2024 05:31:57 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:b623:41fc:e293:c9b1? ([2a01:e0a:982:cbb0:b623:41fc:e293:c9b1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43160dbe73bsm23197135e9.4.2024.10.18.05.31.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Oct 2024 05:31:56 -0700 (PDT) Message-ID: <5ad8f396-84a5-486d-b90d-98fbf8882d1b@linaro.org> Date: Fri, 18 Oct 2024 14:31:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Amlogic A4 SoCs To: Krzysztof Kozlowski , Jerome Brunet , Xianwei Zhao Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , Bartosz Golaszewski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241018-a4_pinctrl-v3-0-e76fd1cf01d7@amlogic.com> <20241018-a4_pinctrl-v3-1-e76fd1cf01d7@amlogic.com> <4a79f996-9d82-48b2-8a93-d7917413ed8c@kernel.org> <1jttd9rein.fsf@starbuckisacylon.baylibre.com> <4127b448-a914-4c69-b938-29512995326f@amlogic.com> <1jmsj1rclh.fsf@starbuckisacylon.baylibre.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_053159_815431_44587FFD X-CRM114-Status: GOOD ( 17.16 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 18/10/2024 12:13, Krzysztof Kozlowski wrote: > On 18/10/2024 11:20, Jerome Brunet wrote: >> On Fri 18 Oct 2024 at 17:01, Xianwei Zhao wrote: >> >>> Hi Jerome, >>> Thanks for your reply. >>> >>> On 2024/10/18 16:39, Jerome Brunet wrote: >>>> [ EXTERNAL EMAIL ] >>>> On Fri 18 Oct 2024 at 10:28, Krzysztof Kozlowski wrote: >>>> >>>>> On 18/10/2024 10:10, Xianwei Zhao via B4 Relay wrote: >>>>>> From: Xianwei Zhao >>>>>> >>>>>> Add the new compatible name for Amlogic A4 pin controller, and add >>>>>> a new dt-binding header file which document the detail pin names. >>>> the change does not do what is described here. At least the description >>>> needs updating. >>>> >>> >>> Will do. >>> >>>> So if the pin definition is now in the driver, does it mean that pins have >>>> to be referenced in DT directly using the made up numbers that are >>>> created in pinctrl-amlogic-a4.c at the beginning of patch #2 ? >>>> >>> >>> Yes. >>> >>>> If that's case, it does not look very easy a read. >>>> >>> >>> It does happen. The pin definition does not fall under the category of >>> binding. >>> >>> https://lore.kernel.org/all/106f4321-59e8-49b9-bad3-eeb57627c921@amlogic.com/ >> >> So the expectation is that people will write something like: >> >> reset-gpios = <&gpio 42 GPIO_ACTIVE_LOW>; >> >> And others will go in the driver to see that is maps to GPIOX_10 ? the number >> being completly made up, with no link to anything HW/Datasheet >> whatsoever ? >> >> This is how things should be done now ? > > Why would you need to do this? Why it cannot be <&gpio 10 > GPIO_ACTIVE_LOW>, assuming it is GPIO 10? > > Bindings have absolutely nothing to do with it. You have GPIO 10, not > 42, right? There's no 1:1 mapping between the number and the pin on Amlogic platforms, so either a supplementary gpio phandle cell is needed to encode the gpio pin group or some bindings header is needed to map those to well known identifiers. Neil > > Best regards, > Krzysztof > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic