From: Carlo Caione <ccaione@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: devicetree@vger.kernel.org, narmstrong@baylibre.com,
khilman@baylibre.com, robh+dt@kernel.org,
srinivas.kandagatla@linaro.org,
linux-amlogic@lists.infradead.org, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] nvmem: meson-efuse: Move data to a container struct
Date: Tue, 30 Jul 2019 10:29:06 +0100 [thread overview]
Message-ID: <5b6825f9-22dc-1656-b5f8-4f785103f827@baylibre.com> (raw)
In-Reply-To: <1jy30f28rr.fsf@starbuckisacylon.baylibre.com>
On 30/07/2019 10:04, Jerome Brunet wrote:
> On Mon 29 Jul 2019 at 19:39, Carlo Caione <ccaione@baylibre.com> wrote:
/cut
>> +struct meson_efuse {
>> + struct nvmem_device *nvmem;
>> + struct nvmem_config config;
>> + struct clk *clk;
>
> since this driver uses devm_add_action_or_reset, I don't think you need
> to keep the clk pointer around, unless you plan to do something with it
> later on ?
Good point about the clk pointer.
> It is kind of the same the other structure members, do we need to keep
> them around ? We could just let devm deal with it ?
>
> If you have a plan, could you share it ?
No plan. In the PATCH 4/5 I was going to add struct meson_sm_firmware to
the bundle and to me it's a bit more elegant to have all the auxiliary
structs together in a single container.
For the sake of keeping the diff size low I'm going to rework this in V2.
--
Carlo Caione
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-07-30 9:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 18:39 [PATCH 0/5] Rework secure-monitor driver Carlo Caione
2019-07-29 18:39 ` [PATCH 1/5] nvmem: meson-efuse: Move data to a container struct Carlo Caione
2019-07-30 9:04 ` Jerome Brunet
2019-07-30 9:29 ` Carlo Caione [this message]
2019-07-29 18:39 ` [PATCH 2/5] firmware: meson_sm: Mark chip struct as static const Carlo Caione
2019-07-30 9:05 ` Jerome Brunet
2019-07-29 18:39 ` [PATCH 3/5] nvmem: meson-efuse: bindings: Add secure-monitor phandle Carlo Caione
2019-07-29 18:39 ` [PATCH 4/5] firmware: meson_sm: Rework driver as a proper platform driver Carlo Caione
2019-07-30 9:18 ` Jerome Brunet
2019-07-29 18:39 ` [PATCH 5/5] arm64: dts: meson: Link nvmem and secure-monitor nodes Carlo Caione
2019-07-30 9:23 ` Jerome Brunet
2019-07-30 9:36 ` Carlo Caione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b6825f9-22dc-1656-b5f8-4f785103f827@baylibre.com \
--to=ccaione@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®