From: Martin Kurbanov <mmkurbanov@sberdevices.ru>
To: Jerome Brunet <jbrunet@baylibre.com>,
Mark Brown <broonie@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: <linux-spi@vger.kernel.org>, <linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kernel@sberdevices.ru>
Subject: Re: [PATCH v2 2/2] spi: amlogic-spifc-a1: add support for max_speed_hz
Date: Thu, 20 Jul 2023 18:41:11 +0300 [thread overview]
Message-ID: <5dc58681-d89f-8a8d-4da5-ccfa142fa15a@sberdevices.ru> (raw)
In-Reply-To: <1jlefm6h8g.fsf@starbuckisacylon.baylibre.com>
On 11.07.2023 10:25, Jerome Brunet wrote:
>>
>> +static int amlogic_spifc_a1_set_freq(struct amlogic_spifc_a1 *spifc, u32 freq)
>> +{
>> + int ret;
>> +
>> + if (freq == spifc->curr_speed_hz)
>> + return 0;
>> +
>> + ret = clk_set_rate(spifc->clk, freq);
>> + if (ret)
>> + return ret;
>> +
>> + spifc->curr_speed_hz = freq;
>
> There is no guarantee that clk_set_rate() has set the rate you have
> requested, at least not precisely. You should call clk_get_rate() here.
>
Hello Jerome, thank you for the feedback.
Are you referring to a situation where there is a change in the rate due
to a request from another client, such as a sibling driver with the same
parent clock?
--
Best Regards,
Martin Kurbanov
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-07-20 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 11:03 [PATCH v2 0/2] spi: amlogic-spifc-a1: fixes and improvements for amlogic-spifc-a1 Martin Kurbanov
2023-07-06 11:03 ` [PATCH v2 1/2] spi: amlogic-spifc-a1: implement adjust_op_size() Martin Kurbanov
2023-07-07 7:51 ` Neil Armstrong
2023-07-06 11:03 ` [PATCH v2 2/2] spi: amlogic-spifc-a1: add support for max_speed_hz Martin Kurbanov
2023-07-07 7:51 ` Neil Armstrong
2023-07-11 7:25 ` Jerome Brunet
2023-07-20 15:41 ` Martin Kurbanov [this message]
2023-07-20 15:46 ` Mark Brown
2023-07-24 15:15 ` Martin Kurbanov
2023-07-11 22:04 ` [PATCH v2 0/2] spi: amlogic-spifc-a1: fixes and improvements for amlogic-spifc-a1 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dc58681-d89f-8a8d-4da5-ccfa142fa15a@sberdevices.ru \
--to=mmkurbanov@sberdevices.ru \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®