From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, khilman@baylibre.com
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] ARM: dts: meson: move iio-hwmon for the SoC temperature to meson.dtsi
Date: Mon, 11 Jan 2021 15:03:01 +0100 [thread overview]
Message-ID: <5ff93086-d913-6465-7af3-9555c1cceba2@baylibre.com> (raw)
In-Reply-To: <20201221181306.904272-2-martin.blumenstingl@googlemail.com>
On 21/12/2020 19:13, Martin Blumenstingl wrote:
> The SoC temperature can be retrieved from ADC channel 8 on all 32-bit
> SoCs (Meson6, Meson8, Meson8b and Meson8m2). Move the iio-hwmon instance
> to meson.dtsi instead of duplicating it in all board.dts.
> If the temperature sensor calibration data is missing for a board then
> iio-hwmon will simply not probe.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm/boot/dts/meson.dtsi | 5 +++++
> arch/arm/boot/dts/meson8b-ec100.dts | 5 -----
> arch/arm/boot/dts/meson8b-mxq.dts | 5 -----
> arch/arm/boot/dts/meson8b-odroidc1.dts | 5 -----
> arch/arm/boot/dts/meson8m2-mxiii-plus.dts | 5 -----
> 5 files changed, 5 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson.dtsi b/arch/arm/boot/dts/meson.dtsi
> index 7649dd1e0b9e..5f074f7aa1a2 100644
> --- a/arch/arm/boot/dts/meson.dtsi
> +++ b/arch/arm/boot/dts/meson.dtsi
> @@ -11,6 +11,11 @@ / {
> #size-cells = <1>;
> interrupt-parent = <&gic>;
>
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&saradc 8>;
> + };
> +
> soc {
> compatible = "simple-bus";
> #address-cells = <1>;
> diff --git a/arch/arm/boot/dts/meson8b-ec100.dts b/arch/arm/boot/dts/meson8b-ec100.dts
> index ed06102a4014..8e48ccc6b634 100644
> --- a/arch/arm/boot/dts/meson8b-ec100.dts
> +++ b/arch/arm/boot/dts/meson8b-ec100.dts
> @@ -70,11 +70,6 @@ gpio-poweroff {
> timeout-ms = <20000>;
> };
>
> - iio-hwmon {
> - compatible = "iio-hwmon";
> - io-channels = <&saradc 8>;
> - };
> -
> leds {
> compatible = "gpio-leds";
>
> diff --git a/arch/arm/boot/dts/meson8b-mxq.dts b/arch/arm/boot/dts/meson8b-mxq.dts
> index 33037ef62d0a..f3937d55472d 100644
> --- a/arch/arm/boot/dts/meson8b-mxq.dts
> +++ b/arch/arm/boot/dts/meson8b-mxq.dts
> @@ -27,11 +27,6 @@ memory {
> reg = <0x40000000 0x40000000>;
> };
>
> - iio-hwmon {
> - compatible = "iio-hwmon";
> - io-channels = <&saradc 8>;
> - };
> -
> vcck: regulator-vcck {
> compatible = "pwm-regulator";
>
> diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> index 5963566dbcc9..c440ef94e082 100644
> --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> @@ -85,11 +85,6 @@ tf_io: gpio-regulator-tf_io {
> 1800000 1>;
> };
>
> - iio-hwmon {
> - compatible = "iio-hwmon";
> - io-channels = <&saradc 8>;
> - };
> -
> rtc32k_xtal: rtc32k-xtal-clk {
> /* X3 in the schematics */
> compatible = "fixed-clock";
> diff --git a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts
> index 8f4eb1ed4581..fa6d55f1cfb9 100644
> --- a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts
> +++ b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts
> @@ -45,11 +45,6 @@ button-function {
> };
> };
>
> - iio-hwmon {
> - compatible = "iio-hwmon";
> - io-channels = <&saradc 8>;
> - };
> -
> vcc_3v3: regulator-vcc3v3 {
> compatible = "regulator-fixed";
> regulator-name = "VCC3V3";
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-01-11 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 18:13 [PATCH 0/5] Thermal zone configuration for Meson8/Meson8b/Meson8m2 Martin Blumenstingl
2020-12-21 18:13 ` [PATCH 1/5] ARM: dts: meson: move iio-hwmon for the SoC temperature to meson.dtsi Martin Blumenstingl
2021-01-11 14:03 ` Neil Armstrong [this message]
2020-12-21 18:13 ` [PATCH 2/5] ARM: dts: meson: add the ADC thermal sensor " Martin Blumenstingl
2021-01-11 14:03 ` Neil Armstrong
2020-12-21 18:13 ` [PATCH 3/5] ARM: dts: meson8: add the thermal-zones with cooling configuration Martin Blumenstingl
2021-01-11 14:04 ` Neil Armstrong
2020-12-21 18:13 ` [PATCH 4/5] ARM: dts: meson8b: " Martin Blumenstingl
2021-01-11 14:04 ` Neil Armstrong
2020-12-21 18:13 ` [PATCH 5/5] ARM: multi_v7_defconfig: Enable support for the ADC thermal sensor Martin Blumenstingl
2021-01-25 18:42 ` [PATCH 0/5] Thermal zone configuration for Meson8/Meson8b/Meson8m2 Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ff93086-d913-6465-7af3-9555c1cceba2@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®