From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 962BDEB64D9 for ; Thu, 6 Jul 2023 07:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y+g/gb3Ds9w0bNCAW2r+OD+Lhpy46BQGoOx4MN/50Js=; b=xkAB7+tINce6zsi41T9h46nbSr r9YbBAHnadoW/t6UEGlnIAYiyfS4DgxgopRis6tF9/PCSowsyMKEBf9yWbTR2AMwC8ahUv63icAFN G0tGEzhGSiHFyDQsTQmQbcLMVcQ3SBeSCIUg3fk/Hg2vNl82efYH4n9+9/X3zLLD0j+XBovjsr5UG kLTH8tH/B2br8I0qDyPFmvXxO7qxaG06SHbBNs1TKBOtfjxDqVqQO7gycuUKLinvEKV7ghQ+tvaZa aQB5PsaRlSkU7vNI2G0Ch7QOn7Gqple7GYIwNOPArK28nAlBFKv4Q0wZXSDGFAXU7xLL4PkiTLxHv pC7h6pHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHIyC-000isN-2Z; Thu, 06 Jul 2023 07:00:04 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHIyA-000iot-0W for linux-amlogic@lists.infradead.org; Thu, 06 Jul 2023 07:00:03 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4fb960b7c9dso371446e87.0 for ; Wed, 05 Jul 2023 23:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688626796; x=1691218796; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ekCygdP574MvHjOEcOXc7gCddg3fyvdxIoCepPcTFCQ=; b=giQdojI1VDIYHQKpiPkPYNZPgbveNNf5P9cKjKO3yo4PktUIwPs5/nySuYYV7lqkeL 5A4ELiPNYIuY/z6vW9ihSmwxniYQ9qphy9TOALeAmDxe8AtjXHZwmhnAoJfrVSCgqd9d 9HSkPSUdNvWugDG/EqJpsigc7QUgS6XAewvnsuf+WqxAr+adB8J3QSPl0LzytcH0k5TR fYvSMaMxKb+7LVjCrcKxPBy04zlviMztD4PnmBs5firNH+o6u8bKiW7e4l+tzt7Oh0V5 R7NyO2S879cNjJJ2CMe1RexDpHj9hpTt9Au8tbVXwWqXZaoErLEKcNFsXJMSa13Dx20Q yyyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688626796; x=1691218796; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ekCygdP574MvHjOEcOXc7gCddg3fyvdxIoCepPcTFCQ=; b=DCETxVHL8Waxd/Iv2JJlkPHoJ2TEwgyhfw21xqHtHLLaxfJrwJYnJGh8qjIA9UbEj/ M//zXdHLcaiftglRthFcXM1BY4Jee+QreFmaE1+qwW6JrWNmxZj9gil4Y3YV8l0bGUgq kWcY40sa8H0AuWtyKJC8Rfl2CVqE/JfohZZnukMHFZl2wKh2xTLq3dW4ZPhVVv+NY3qq pNrJt6/er8Nm+dfnf4bw7hmsM9LwsKvY3DcNo1tAbI/puCzrxq/dS0TEB9ciW8O23tV6 op+Gg7FWxnep0KrEOpKVOOl5aCUIxiRv166dxlyJWq/IRS2nnGGYrneXtUKgoIOV7t2W 5AdQ== X-Gm-Message-State: ABy/qLYWoC0lSvrkguuESRTtGiRqKvwau8qtilEGy/2wTcvgxx2pQ6RE ZgAZBqcxP055/L+PPnUqD1ceYkknMqyy7LJ/P5H7HgUV X-Google-Smtp-Source: APBJJlEsz6Fhpg12b102ApIe1RIyCXh4cNJ1O9HJo8CHhGB8sIkBqYMirtS3Gcv3aAz1DsYthrYKkw== X-Received: by 2002:a05:6512:3703:b0:4f8:7697:5207 with SMTP id z3-20020a056512370300b004f876975207mr641642lfr.23.1688626795843; Wed, 05 Jul 2023 23:59:55 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:15d1:2748:ead4:bdff? ([2a01:e0a:982:cbb0:15d1:2748:ead4:bdff]) by smtp.gmail.com with ESMTPSA id f12-20020a7bcd0c000000b003fbd9e390e1sm4147027wmj.47.2023.07.05.23.59.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 23:59:55 -0700 (PDT) Message-ID: <60927fc6-2819-a01a-6ea8-f1af301b1bad@linaro.org> Date: Thu, 6 Jul 2023 08:59:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 From: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/7] tty: serial: meson: redesign the module to platform_driver Content-Language: en-US To: Dmitry Rokosov , gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jbrunet@baylibre.com, jirislaby@kernel.org, khilman@baylibre.com, martin.blumenstingl@googlemail.com Cc: kelvin.zhang@amlogic.com, xianwei.zhao@amlogic.com, kernel@sberdevices.ru, rockosov@gmail.com, linux-amlogic@lists.infradead.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230705181833.16137-1-ddrokosov@sberdevices.ru> <20230705181833.16137-3-ddrokosov@sberdevices.ru> Organization: Linaro Developer Services In-Reply-To: <20230705181833.16137-3-ddrokosov@sberdevices.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230706_000002_216653_D98B4E73 X-CRM114-Status: GOOD ( 24.92 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 05/07/2023 20:18, Dmitry Rokosov wrote: > Actually, the meson_uart module is already a platform_driver, but it is > currently registered manually and the uart core registration is run > outside the probe() scope, which results in some restrictions. For > instance, it is not possible to communicate with the OF subsystem > because it requires an initialized device object. > > To address this issue, apply module_platform_driver() instead of direct > module init/exit routines. Additionally, move uart_register_driver() to > the driver probe(), and destroy manual console registration because it's > already run in the uart_register_driver() flow. > > Signed-off-by: Dmitry Rokosov > --- > drivers/tty/serial/meson_uart.c | 51 ++++++++++----------------------- > 1 file changed, 15 insertions(+), 36 deletions(-) > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > index bca54f3d92a1..dcf994a11a21 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -621,12 +621,6 @@ static struct console meson_serial_console = { > .data = &meson_uart_driver, > }; > > -static int __init meson_serial_console_init(void) > -{ > - register_console(&meson_serial_console); > - return 0; > -} > - > static void meson_serial_early_console_write(struct console *co, > const char *s, > u_int count) > @@ -652,9 +646,6 @@ OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", > > #define MESON_SERIAL_CONSOLE (&meson_serial_console) > #else > -static int __init meson_serial_console_init(void) { > - return 0; > -} > #define MESON_SERIAL_CONSOLE NULL > #endif > > @@ -738,6 +729,13 @@ static int meson_uart_probe(struct platform_device *pdev) > if (ret) > return ret; > > + if (!meson_uart_driver.state) { > + ret = uart_register_driver(&meson_uart_driver); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, > + "can't register uart driver\n"); > + } > + > port->iotype = UPIO_MEM; > port->mapbase = res_mem->start; > port->mapsize = resource_size(res_mem); > @@ -776,6 +774,13 @@ static int meson_uart_remove(struct platform_device *pdev) > uart_remove_one_port(&meson_uart_driver, port); > meson_ports[pdev->id] = NULL; > > + for (int id = 0; id < AML_UART_PORT_NUM; id++) > + if (meson_ports[id]) > + return 0; > + > + /* No more available uart ports, unregister uart driver */ > + uart_unregister_driver(&meson_uart_driver); > + > return 0; > } > > @@ -809,33 +814,7 @@ static struct platform_driver meson_uart_platform_driver = { > }, > }; > > -static int __init meson_uart_init(void) > -{ > - int ret; > - > - ret = meson_serial_console_init(); > - if (ret) > - return ret; > - > - ret = uart_register_driver(&meson_uart_driver); > - if (ret) > - return ret; > - > - ret = platform_driver_register(&meson_uart_platform_driver); > - if (ret) > - uart_unregister_driver(&meson_uart_driver); > - > - return ret; > -} > - > -static void __exit meson_uart_exit(void) > -{ > - platform_driver_unregister(&meson_uart_platform_driver); > - uart_unregister_driver(&meson_uart_driver); > -} > - > -module_init(meson_uart_init); > -module_exit(meson_uart_exit); > +module_platform_driver(meson_uart_platform_driver); > > MODULE_AUTHOR("Carlo Caione "); > MODULE_DESCRIPTION("Amlogic Meson serial port driver"); Reviewed-by: Neil Armstrong _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic