From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Zhang Ning <zhangn1985@qq.com>
Cc: martin.blumenstingl@googlemail.com, narmstrong@baylibre.com,
linux-amlogic@lists.infradead.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, sean@mess.org,
devicetree@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [v5 4/4] arm64: dts: meson: Add MagicBox M16S support
Date: Tue, 26 Jul 2022 08:48:45 +0200 [thread overview]
Message-ID: <62334f55-df8a-936a-ec88-2db469aede21@linaro.org> (raw)
In-Reply-To: <tencent_1B5B069917D86370ED4136BDD2C413240D08@qq.com>
On 26/07/2022 02:04, Zhang Ning wrote:
>>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts
>>> @@ -0,0 +1,40 @@
>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>> +/*
>>> + * Copyright (c) 2022 Zhang Ning <zhangn1985@qq.com>
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "meson-gxm.dtsi"
>>> +#include "meson-gx-p23x-q20x.dtsi"
>>> +#include <dt-bindings/input/input.h>
>>> +
>>> +/ {
>>> + compatible = "magicbox,m16s", "amlogic,s912", "amlogic,meson-gxm";
>>> + model = "MagicBox M16S";
>>> +
>>> + gpio-keys-polled {
>>
>> Just gpio-keys (or even "keys").
> I see all dts for amlogic platform are using gpio-keys-polled, could I
> keep current name?
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-07-26 6:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220724231704.132472-1-zhangn1985@qq.com>
2022-07-24 23:17 ` [v5 1/4] media: rc: add keymap for MagicBox M16S remote Zhang Ning
2022-07-26 0:31 ` Zhang Ning
2022-07-24 23:17 ` [v5 2/4] " Zhang Ning
2022-07-26 7:42 ` Sean Young
2022-07-26 8:53 ` Zhang Ning
2022-07-24 23:17 ` [v5 3/4] dt-bindings: arm: add Magicbox M16S bindings Zhang Ning
2022-07-25 16:31 ` Krzysztof Kozlowski
2022-07-26 0:00 ` Zhang Ning
2022-07-24 23:17 ` [v5 4/4] arm64: dts: meson: Add MagicBox M16S support Zhang Ning
2022-07-25 16:32 ` Krzysztof Kozlowski
2022-07-26 0:04 ` Zhang Ning
2022-07-26 6:48 ` Krzysztof Kozlowski [this message]
2022-07-26 8:51 ` Zhang Ning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62334f55-df8a-936a-ec88-2db469aede21@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
--cc=zhangn1985@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®