Re: [PATCH v5 3/6] dt-bindings: Asoc: axg-audio: Add s4 audio tocodec

From: Jiebing Chen <jiebing.chen@amlogic.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
	jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com
Subject: Re: [PATCH v5 3/6] dt-bindings: Asoc: axg-audio: Add s4 audio tocodec
Date: Mon, 14 Jul 2025 15:31:58 +0800	[thread overview]
Message-ID: <6846c3f5-0d73-44d7-9330-5edce7813f0e@amlogic.com> (raw)
In-Reply-To: <b8d61abb-a6a6-49cd-94c3-f397bb30203e@kernel.org>

在 2025/7/14 15:22, Krzysztof Kozlowski 写道:
> [ EXTERNAL EMAIL ]
>
> On 14/07/2025 08:10, Krzysztof Kozlowski wrote:
>> On 10/07/2025 05:35, jiebing chen via B4 Relay wrote:
>>> From: jiebing chen <jiebing.chen@amlogic.com>
>>>
>>> Add S4 SoC tocodec compatibility support.
>>>
>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>> Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
>>> ---
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>>
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It seems my or other reviewer's previous comments were not fully
>> addressed. Maybe the feedback got lost between the quotes, maybe you
>> just forgot to apply it. Please go back to the previous discussion and
>> either implement all requested changes or keep discussing them.
>>
>> Thank you.
>> </form letter>
>>
> You responded in private, but that's not how we discuss here. Please
> keep all discussions public.
>
> Above form letter means you received feedback at v1 or v2 and you did
> not implement it. You did not respond to it, either.
>
> Please go back to v1 or v2 and implement entire feedback.

thanks, I will refer to the previous submission.

3fda85324b8d ASoC: dt-bindings: Extend name-prefix.yaml into common DAI
properties

ASoC: dt-bindings:

>
> Best regards,
> Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic