From: Chuan Liu <chuan.liu@amlogic.com>
To: Carlo Caione <ccaione@baylibre.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jian Hu <jian.hu@amlogic.com>, Yu Tu <yu.tu@amlogic.com>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] clk: meson: s4: fix ENCP clock selection
Date: Fri, 23 Oct 2026 14:00:06 +0800 [thread overview]
Message-ID: <6abe6927-71b4-4bbd-8d63-fffcda43f0ec@amlogic.com> (raw)
In-Reply-To: <20261022-upstream-clk-encp-sel-shift-v1-3-f1b1e10a3d84@baylibre.com>
Hi Carlo,
Thanks for the fix.
On 10/23/2026 4:10 AM, Carlo Caione wrote:
> [????????? ccaione@baylibre.com ????????? https://aka.ms/LearnAboutSenderIdentification?????????????]
>
> [ EXTERNAL EMAIL ]
>
> The ENCP clock uses ENCT's settings by mistake. Change the selector
> from bits [23:20] to [27:24].
Yes, you are right.
By the way, S4 does not support the ENCT (Encoder for TV Panel) so the
driver does not define the associated clocks.
>
> See the S905Y4 datasheet v0.7, Table 7-58.
>
> Fixes: 57b55c76aaf1 ("clk: meson: S4: add support for Amlogic S4 SoC peripheral clock controller")
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Reviewed-by: Chuan Liu <chuan.liu@amlogic.com>
> ---
> drivers/clk/meson/s4-peripherals.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/s4-peripherals.c b/drivers/clk/meson/s4-peripherals.c
> index ba41fcd90588..33573eb85927 100644
> --- a/drivers/clk/meson/s4-peripherals.c
> +++ b/drivers/clk/meson/s4-peripherals.c
> @@ -1114,7 +1114,7 @@ static struct clk_regmap s4_cts_encp_sel = {
> .data = &(struct clk_regmap_mux_data){
> .offset = CLKCTRL_VID_CLK_DIV,
> .mask = 0xf,
> - .shift = 20,
> + .shift = 24,
> .table = s4_cts_parents_val_table,
> },
> .hw.init = &(struct clk_init_data){
>
> --
> 2.56.0
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
--
Best regards,
Chuan
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2026-10-23 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 20:10 [PATCH 0/3] Fix the ENCP clock select field on GXBB, G12A and S4 Carlo Caione
2026-10-22 20:10 ` [PATCH 1/3] clk: meson: gxbb: fix ENCP clock selection Carlo Caione
2026-10-22 20:10 ` [PATCH 2/3] clk: meson: g12a: " Carlo Caione
2026-10-22 20:10 ` [PATCH 3/3] clk: meson: s4: " Carlo Caione
2026-10-23 6:00 ` Chuan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6abe6927-71b4-4bbd-8d63-fffcda43f0ec@amlogic.com \
--to=chuan.liu@amlogic.com \
--cc=bmasney+clk@redhat.com \
--cc=ccaione@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=sboyd@kernel.org \
--cc=yu.tu@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®