From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Kalle Valo <kvalo@kernel.org>, Eric Dumazet <edumazet@google.com>,
Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>,
Alexander Prutskov <alep@cypress.com>,
Joseph chuang <jiac@cypress.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Angus Ainslie <angus@akkea.ca>, Pierre-Hugues Husson <phh@phh.me>,
linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-amlogic@lists.infradead.org
Subject: Re: [RFC PATCH] brcmfmac: add 43751 SDIO ids and initialization
Date: Mon, 13 Mar 2023 22:42:08 +0100 [thread overview]
Message-ID: <6ac1ecb1-eba4-b0a3-579c-afcbe532a474@free.fr> (raw)
In-Reply-To: <CAFBinCDHRhLSyFsEv7cdhSgZorj-TdR3HhqSBnAQcUtEsecV=Q@mail.gmail.com>
On 13/03/2023 21:04, Martin Blumenstingl wrote:
> On Mon, Mar 13, 2023 at 6:09 PM Marc Gonzalez wrote:
> [...]
>> QUESTION:
>> It's not clear to me why we sleep twice for host->ios.power_delay_ms?
>
> I'm not sure but I think host->ios.power_delay_ms is independent from
> the post-power-on-delay-ms property of "mmc-pwrseq-simple".
They are distinct indeed (the props have the same name & similar purpose though).
host->ios.power_delay_ms is set via:
drivers/mmc/core/host.c: device_property_read_u32(dev, "post-power-on-delay-ms",
drivers/mmc/core/host.c- &host->ios.power_delay_ms);
pwrseq->post_power_on_delay_ms is set via:
drivers/mmc/core/pwrseq_simple.c: device_property_read_u32(dev, "post-power-on-delay-ms",
drivers/mmc/core/pwrseq_simple.c- &pwrseq->post_power_on_delay_ms);
However, they are both used to delay mmc_power_up(),
and the host delay is used to sleep twice, which I
found confusing ;)
Regards
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-03-13 21:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 18:19 Unsupported WiFi adapter on S905X2 board Marc Gonzalez
2023-03-06 9:17 ` Neil Armstrong
2023-03-06 10:24 ` [RFC PATCH] brcmfmac: add 43751 SDIO ids and initialization Marc Gonzalez
2023-03-06 10:41 ` Marc Gonzalez
2023-03-07 14:40 ` Marc Gonzalez
2023-03-07 23:15 ` Franky Lin
2023-03-08 12:47 ` Marc Gonzalez
2023-03-08 17:21 ` Franky Lin
2023-03-08 17:37 ` Neil Armstrong
2023-03-22 17:40 ` Marc Gonzalez
2023-04-04 15:59 ` Marc Gonzalez
2023-03-09 10:16 ` Marc Gonzalez
2023-03-09 12:13 ` Marc Gonzalez
2023-03-09 14:29 ` Ulf Hansson
2023-03-09 16:45 ` Marc Gonzalez
2023-03-09 17:51 ` Marc Gonzalez
2023-03-13 13:55 ` Marc Gonzalez
2023-03-13 14:41 ` Marc Gonzalez
2023-03-13 14:53 ` Marc Gonzalez
2023-03-13 17:09 ` Marc Gonzalez
2023-03-13 20:04 ` Martin Blumenstingl
2023-03-13 21:42 ` Marc Gonzalez [this message]
2023-03-14 7:27 ` Ulf Hansson
[not found] ` <c7e48c6f-530b-7198-b8bb-fc927a2fdc66@free.fr>
2023-03-14 11:08 ` Ulf Hansson
2023-03-14 16:37 ` Marc Gonzalez
2023-03-15 20:55 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac1ecb1-eba4-b0a3-579c-afcbe532a474@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=alep@cypress.com \
--cc=angus@akkea.ca \
--cc=aspriel@gmail.com \
--cc=edumazet@google.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=jbrunet@baylibre.com \
--cc=jiac@cypress.com \
--cc=khilman@baylibre.com \
--cc=kvalo@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=phh@phh.me \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®