From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2844EC3ABBC for ; Fri, 9 May 2025 17:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6fnXNzh3rBHSBEhK5bmoIN/W4WAo9cbR0oI5CRhmm2w=; b=N4DiFnG1K8IV0jDUA7kILa972a 0wI8IyjwhjZork24OEjGxYa1CoSssBAfdoj+QjlzjjNRiXdulQzw62cFzCBLM5iIlrkAAikUm9ZYu jgnyGP9/ceCHkWqg1HE7yBtqZnv8opkOW7RaBNDig66aDBWRokEjkdq5HbhcFa255L/qdm2Gc3+ip MrIatahyhlXkHFKNrEDftZqAhlVhrCDpHNJQDENxDoWy6od/TCC3MaPMFzrDv6Dm9WPB/5Brr3iCI rXpedRBYSe+nhhcuRSWUAiI0SayLnAdkIlHgrbyWp6GAlIxZg4Wqd4PuVwe9NiV9z+hCLX56FrP0Q ssPWfgRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDRfc-00000004SW2-1joe; Fri, 09 May 2025 17:38:00 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDPlC-000000046ef-3A5t for linux-amlogic@lists.infradead.org; Fri, 09 May 2025 15:35:40 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3a0b6aa08e5so2011394f8f.1 for ; Fri, 09 May 2025 08:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746804936; x=1747409736; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=8Lf024pTfan+q9P4HvlL7cyqlLI9Q/+p93cpsiJhSK4=; b=EBeQLqPRsHOerBbmUkvdNXLmEom4uFrDHBfo3plXdv3uYaoraOM6qQaely2k++yd4f dE/AeTVzJf5kOKSL2LeLxYieTQev0u4clXPwklsLe1dNCNRRQvQ713pc40AnBCBRmkNh Ot3HDwcBv0PAsksrv9/RPalZu1gGNk8tPVfG2t8RTm81rFYcu/prSu2mCGHhh2tofEGr b3N4lHAcqm5k5E00v6RtW2eNIyu0uK9INUat/PLCPE1TsqyGQ53PEoFQJfETd5gCIQjX 1h9nOhG3NRPqFWG8gsBRUbUYyBfZfj9c4RwM/jK9jW2W5EhkfTo2shDAHhBybngIvoZN WL7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746804936; x=1747409736; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8Lf024pTfan+q9P4HvlL7cyqlLI9Q/+p93cpsiJhSK4=; b=A36q4XN9NkHbDyDgiU23lUqxK8+VgGIMwqkiKfTYl2U/ex8JcDr9aCGt5h1+kQnuMH fch8jm1oMjTNLN3v0VI7f9IOA1XI+2T5kKo/FNQvTHc7WQ2v2he4RWEfBE32XurLbvBV LzTOuzYkuGJJsj1MZ84QlbwD2uAZu82rt5y6dFxU1/rMd33MhHIj/xCWnk4dR9YmO8de x5PCHOMkeACTU8VFYqkth/cBas6/7sAEnC3yPp/EuxY4acOQLJCA34oqctl8FdVJ1dMr gnaagW61qitxTlqTbz2UgfjhI8RDX/LiAhZDZFHdsU4BmVEc0iHYtwKRfne3KReoYZZQ DOuA== X-Forwarded-Encrypted: i=1; AJvYcCVw64Vpq9WkRxLO8bXu+O9a5EwIx8PSnLQOTUDi8BDJkF+AvJYwgKRTxhNWmDCaT48mJvnKC3M4B78NIVri@lists.infradead.org X-Gm-Message-State: AOJu0YyHU7XMJiWCbCmwjWAxScuWmY/i79aIaKe5FE8BXzEzg5sJsSUW kpd/s/d/LwslDIXsi1Xz/dsGcM4s6LeFzdwVgh31TS38YNzkIG1kr+YeNgYCVpE= X-Gm-Gg: ASbGncviRvjVg+QsEP3S9TrG/Y/b1YzRuoDZqCpbnlayjhu7OwfudnDbX19wRDBwYCN B64giXQWgcAgbRRScTNZjBHrAJlD8tNB41NeqNdhINmotzjOjFJ3uH/Yiqb6faiL3KDauNbF3FQ wODghOfBk1pkCE7z1XaHdO7XwqWli5Le0ZEIAqMcS7+azlKvQXDNSoF0gLxEd4H410/8Kt49Gkg 2F7u9Q5He8vXkB2tl0krHVlAkG7aHiyRvn6K0VPwKGJrB6Zpdpr85ZKokpggvvNEtgB/HiRvi3y YN/XgV91MLgjHP7VbCVggHJTXsYCyCg/DGG6BuDGwqvTTfHiHLzeDB0SWnPQ8xZzJOpdvy/lD57 qilNH+pXP7hYbRuE= X-Google-Smtp-Source: AGHT+IHee8AoQ48Wmh4QoUcNKP20otCxG3keyweeVnCtmCpXbPFY1XMvweqwVZVtf5GlL3zDrP25Eg== X-Received: by 2002:a5d:5f86:0:b0:39b:f44b:e176 with SMTP id ffacd0b85a97d-3a0b99504f7mr7296980f8f.24.1746804936618; Fri, 09 May 2025 08:35:36 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:22d7:71a:9f62:f7e2? ([2a01:e0a:3d9:2080:22d7:71a:9f62:f7e2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58f2961sm3570883f8f.45.2025.05.09.08.35.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 08:35:36 -0700 (PDT) Message-ID: <6d2f35ee-1b33-40b6-b164-ab4480110e49@linaro.org> Date: Fri, 9 May 2025 17:35:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Subject: Re: [PATCH v2] drm/meson: Use 1000ULL when operating with mode->clock To: I Hsin Cheng Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, christophe.jaillet@wanadoo.fr, skhan@linuxfoundation.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250505184338.678540-1-richard120310@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250505184338.678540-1-richard120310@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250509_083538_789346_A88A74D1 X-CRM114-Status: GOOD ( 21.54 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 05/05/2025 20:43, I Hsin Cheng wrote: > Coverity scan reported the usage of "mode->clock * 1000" may lead to > integer overflow. Use "1000ULL" instead of "1000" > when utilizing it to avoid potential integer overflow issue. > > Link: https://scan5.scan.coverity.com/#/project-view/10074/10063?selectedIssue=1646759 > Signed-off-by: I Hsin Cheng Could you add a Fixes tag ? Thanks, Neil > --- > Changelog: > > v1 -> v2: > - Use 1000ULL instead of casting the type of "mode->clock" > - Refine commit title and message > - Fix the issue for the evaluation inside drm_mode_status > meson_encoder_hdmi_mode_valid() as well > > Christophe, > Thanks for your review and your suggestion, I think I should add a tag > for you,too, but I'm not sure what should I add, if you would be so kind > please let me know how should I tag you in the patch. > > Best regards, > I Hsin Cheng > --- > drivers/gpu/drm/meson/meson_encoder_hdmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c b/drivers/gpu/drm/meson/meson_encoder_hdmi.c > index 7752d8ac85f0..c08fa93e50a3 100644 > --- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c > @@ -75,7 +75,7 @@ static void meson_encoder_hdmi_set_vclk(struct meson_encoder_hdmi *encoder_hdmi, > unsigned long long venc_freq; > unsigned long long hdmi_freq; > > - vclk_freq = mode->clock * 1000; > + vclk_freq = mode->clock * 1000ULL; > > /* For 420, pixel clock is half unlike venc clock */ > if (encoder_hdmi->output_bus_fmt == MEDIA_BUS_FMT_UYYVYY8_0_5X24) > @@ -123,7 +123,7 @@ static enum drm_mode_status meson_encoder_hdmi_mode_valid(struct drm_bridge *bri > struct meson_encoder_hdmi *encoder_hdmi = bridge_to_meson_encoder_hdmi(bridge); > struct meson_drm *priv = encoder_hdmi->priv; > bool is_hdmi2_sink = display_info->hdmi.scdc.supported; > - unsigned long long clock = mode->clock * 1000; > + unsigned long long clock = mode->clock * 1000ULL; > unsigned long long phy_freq; > unsigned long long vclk_freq; > unsigned long long venc_freq; _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic