Re: [PATCH] perf/amlogic: resolve conflict between canvas & pmu

From: Neil Armstrong <neil.armstrong@linaro.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Jiucheng Xu <jiucheng.xu@amlogic.com>,
	AML <linux-amlogic@lists.infradead.org>,
	Chris Healy <healych@amazon.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Pierre-Hugues Husson <phh@phh.me>
Subject: Re: [PATCH] perf/amlogic: resolve conflict between canvas & pmu
Date: Mon, 27 Mar 2023 09:48:40 +0200	[thread overview]
Message-ID: <6d75de34-3de7-16b7-9d16-70f95b4e14e4@linaro.org> (raw)
In-Reply-To: <CAFBinCDmzgh2eHbJHbi+90DQsyUqUgoxHmqha3URD0KZmi5T5Q@mail.gmail.com>

On 25/03/2023 21:54, Martin Blumenstingl wrote:
> Hi Marc,
> 
> thanks for working on this!
> 
> On Thu, Mar 23, 2023 at 5:24 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>>
>> According to S905X2 Datasheet - Revision 07:
>>
>> DMC_MON area spans 0xff638080-0xff6380c0
>> DDR_PLL area spans 0xff638c00-0xff638c34
>>
>> Round DDR_PLL area size up to 0x40
>>
>> Fixes: 90cf8e21016f ("arm64: dts: meson: Add DDR PMU node")
> This is only partially correct. We also need:
> Fixes: 2016e2113d35 ("perf/amlogic: Add support for Amlogic meson G12
> SoC DDR PMU driver")
> 
>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
>> ---
>>   arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 12 ++++++------
>>   drivers/perf/amlogic/meson_g12_ddr_pmu.c          | 34 +++++++++++++++++-----------------
> I think it makes sense to split this patch into two separate patches,
> each of them with the proper Fixes tag attached (and subject prefix).
> That way the maintainers of the according files can pick them up (.dts
> and driver changes usually go through different trees, I expect this
> to be the case here as well).
> 
> My understanding is that the driver changes will go through a tree
> other than the Amlogic one (I suspect it's Will Deacon's tree).
> Please Cc the other maintainers and mailing lists as shown by
> scripts/get_maintainer.pl:
>    Will Deacon <will@kernel.org> (maintainer:ARM PMU PROFILING AND DEBUGGING)
>    Mark Rutland <mark.rutland@arm.com> (maintainer:ARM PMU PROFILING
> AND DEBUGGING)
>    linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic
> Meson SoC support)
> 
> The contents of the patch look good to me - so this is only about
> organizing things.

The content is good, but can you send the 3 patches (DMC range, DT fix, Driver fix)
in a separate patchset ?

And avoid sending patches in reply to other patchsets/discussions, this messes things out.

Thanks !
Neil

> 
> 
> Best regards,
> Martin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic