From: pure.logic@nexus-software.ie (Bryan O'Donoghue)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long
Date: Sun, 31 Dec 2017 13:40:07 +0000 [thread overview]
Message-ID: <6d83a5c3-6589-24bc-4ca5-4d1bbca47432@nexus-software.ie> (raw)
In-Reply-To: <9f4bef5a-8a71-6f30-5cfb-5e8fe133e3d3@kapsi.fi>
On 30/12/17 16:36, Mikko Perttunen wrote:
> FWIW, we had this problem some years ago with the Tegra CPU clock - then
> it was determined that a simpler solution was to have the determine_rate
> callback support unsigned long rates - so clock drivers that need to
> return rates higher than 2^31 can instead implement the determine_rate
> callback. That is what's currently implemented.
>
> Mikko
Granted we could work around it but, having both zero and less than zero
indicate error means you can't support larger than LONG_MAX which is I
think worth fixing.
---
bod
next prev parent reply other threads:[~2017-12-31 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1514596392-22270-1-git-send-email-pure.logic@nexus-software.ie>
2017-12-30 1:12 ` Bryan O'Donoghue
2017-12-30 16:36 ` Mikko Perttunen
2017-12-31 13:40 ` Bryan O'Donoghue [this message]
2018-01-02 19:01 ` Stephen Boyd
2018-01-02 20:43 ` Bryan O'Donoghue
2018-01-02 23:28 ` Stephen Boyd
2018-01-01 14:41 ` kbuild test robot
2018-01-01 14:47 ` kbuild test robot
2018-01-01 18:01 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d83a5c3-6589-24bc-4ca5-4d1bbca47432@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®