From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5154C61DA4 for ; Fri, 3 Feb 2023 08:03:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PBkuTDv0y/8HFX5tw2UsDa2etx8kayOdC/34TozPnkg=; b=DaCAONi49okm9n cKb1R9Xik0VyoVpduLKJKvD4wik9KdH/rKDnGryQi/VUvYzes0/mbsjLfaSWx1DBDyq0Go4v0HngX Ll/gHwzxvJ7O9xiq2DnXC7AhRVM8zxMzSnXxzio8NNuyms3GXshtW6x9LUs+Ib4v36kedZsf26a7/ Sz21+2hDjNJJIuFtLxAsxjXEzhRD2va49e/VuhjGdatEp6W+p2xNOb8ib4Uj/iVchKrJehRIrR0UJ ZRPp38loFKuQg9gJVO6+wm+I40GUJbjaq+QjF70r3eAsU8dGDyDUBVZFZazUVE5LJqeiMZ3cj1ph8 tmQ/YHlLbqbgbyitWB9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNr24-000v1O-Rq; Fri, 03 Feb 2023 08:02:52 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNr21-000uz5-Ix for linux-amlogic@lists.infradead.org; Fri, 03 Feb 2023 08:02:51 +0000 Received: by mail-wm1-x331.google.com with SMTP id u10so159949wmj.3 for ; Fri, 03 Feb 2023 00:02:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j/BqAshhUQwOb3XRj7imW0y64r6HrCHnAtk8R5uEluo=; b=rq7Eu0AMSJYRKJazkb10W8riHm1cFWqvmIxseSjsriU+YZ5WzlIwiVcSb+yMDtoMQc QlVwfaT5Xep7ONtrUjmbXYzlVppvCON28e/aFwCduAtLMDMN2WijfK105l4ccfbHj37t 6OPt7OK58i56G7Bg/cOaZyXUvtHN21w5Zl0b8Hf9EqGfzJa6WG3eLWNEjaFcHdyUXoIU f96np5sFywJx3Ioo7OGmN3x+9S6/BXbGI06lxlKVSb8ouzQfNR8QiDI9Ef43YlajuS+k noVi5OcH39f3cOBa0lEK6iDEFs3op3kFMNGDq5v2o/+GyOG4JYpUTJlxn0zzKtdGjYMj S7gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j/BqAshhUQwOb3XRj7imW0y64r6HrCHnAtk8R5uEluo=; b=gN/L5QZsz/zWW2wyCulUOLcOk9FIpRNyL5y4eDJMgV6eoEiZbQTPzDNxTVRqNEpyjq Ob5Ouj2Ew0Q7wc5vpcMabp07guCODeiErTLsFrdwLvVKia7DpDewageUI3wkGyoPb5UU +EUS6ZBbRql6oUYlS2zJYXJoULPNg7E2IX4FMIj/Js1w1Sl1tF0B+GoblPJ7bvZUaBQY 8oWs+Lyt2MM9HpQwOJ5m5ncSU1mQKdpXLxeqLIju4pQo5D9QdF5STKOtPkipVqyL5i3F G5/jQz57Ul05yYre/EJTAjidBUzJ/8YlnZbnZ+oUbQnIb8dcIYczV11k9qm2knDCWxzM Lcgg== X-Gm-Message-State: AO0yUKUXXE39RI0Cs9XFW6pWf+xQGpiV+7dKUgvYsVUKE+/Tfjp2fzCS wFb/nSi9i2YBtusH9Z3RY1j2sg== X-Google-Smtp-Source: AK7set/Vb7i53/SV+BeFDBTbUdIAfdaPM5HH1OgiUxRcY1vKNvD0ss4XksA9GmnEstT0xSJMQn7pKA== X-Received: by 2002:a05:600c:1e87:b0:3dc:353c:8b44 with SMTP id be7-20020a05600c1e8700b003dc353c8b44mr8608293wmb.5.1675411368292; Fri, 03 Feb 2023 00:02:48 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id y6-20020a7bcd86000000b003dc4480df80sm7031839wmj.34.2023.02.03.00.02.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 00:02:47 -0800 (PST) Message-ID: <6e6ed493-4748-46ca-7a26-fe9cf6e2377a@linaro.org> Date: Fri, 3 Feb 2023 09:02:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 6/9] ASoC: dt-bindings: meson: convert axg fifo to schema Content-Language: en-US To: Jerome Brunet , Mark Brown , alsa-devel@alsa-project.org, devicetree@vger.kernel.org Cc: linux-amlogic@lists.infradead.org, Kevin Hilman , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org References: <20230202183653.486216-1-jbrunet@baylibre.com> <20230202183653.486216-7-jbrunet@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20230202183653.486216-7-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_000249_700278_E348ACBB X-CRM114-Status: GOOD ( 22.78 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 02/02/2023 19:36, Jerome Brunet wrote: > Convert the DT binding documentation for the Amlogic axg audio FIFOs to > schema. > > Signed-off-by: Jerome Brunet > --- > .../bindings/sound/amlogic,axg-fifo.txt | 34 ----- > .../bindings/sound/amlogic,axg-fifo.yaml | 116 ++++++++++++++++++ > 2 files changed, 116 insertions(+), 34 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > deleted file mode 100644 > index fa4545ed81ca..000000000000 > --- a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt > +++ /dev/null > @@ -1,34 +0,0 @@ > -* Amlogic Audio FIFO controllers > - > -Required properties: > -- compatible: 'amlogic,axg-toddr' or > - 'amlogic,axg-toddr' or > - 'amlogic,g12a-frddr' or > - 'amlogic,g12a-toddr' or > - 'amlogic,sm1-frddr' or > - 'amlogic,sm1-toddr' > -- reg: physical base address of the controller and length of memory > - mapped region. > -- interrupts: interrupt specifier for the fifo. > -- clocks: phandle to the fifo peripheral clock provided by the audio > - clock controller. > -- resets: list of reset phandle, one for each entry reset-names. > -- reset-names: should contain the following: > - * "arb" : memory ARB line (required) > - * "rst" : dedicated device reset line (optional) > -- #sound-dai-cells: must be 0. > -- amlogic,fifo-depth: The size of the controller's fifo in bytes. This > - is useful for determining certain configuration such > - as the flush threshold of the fifo > - > -Example of FRDDR A on the A113 SoC: > - > -frddr_a: audio-controller@1c0 { > - compatible = "amlogic,axg-frddr"; > - reg = <0x0 0x1c0 0x0 0x1c>; > - #sound-dai-cells = <0>; > - interrupts = ; > - clocks = <&clkc_audio AUD_CLKID_FRDDR_A>; > - resets = <&arb AXG_ARB_FRDDR_A>; > - fifo-depth = <512>; > -}; > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > new file mode 100644 > index 000000000000..f6222ad08880 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-fifo.yaml > @@ -0,0 +1,116 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/amlogic,axg-fifo.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic AXG Audio FIFO controllers > + > +maintainers: > + - Jerome Brunet > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + $nodename: > + pattern: "^audio-controller@.*" > + > + compatible: > + oneOf: > + - items: > + - enum: > + - amlogic,axg-toddr > + - amlogic,axg-frddr > + - items: > + - enum: > + - amlogic,g12a-toddr > + - amlogic,sm1-toddr > + - const: > + amlogic,axg-toddr > + - items: > + - enum: > + - amlogic,g12a-frddr > + - amlogic,sm1-frddr > + - const: > + amlogic,axg-frddr > + All usual comments apply. > + reg: > + maxItems: 1 > + > + "#sound-dai-cells": > + const: 0 > + > + clocks: > + items: > + - description: Peripheral clock > + > + interrupts: > + maxItems: 1 > + > + resets: > + items: > + - description: Memory ARB line > + - description: Dedicated device reset line This won't work without minItems and you should see errors on your DTS or in dt_binding_check > + > + reset-names: true minItems maxItems > + > + amlogic,fifo-depth: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Size of the controller's fifo in bytes > + > +required: Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic