From: Neil Armstrong <narmstrong@baylibre.com>
To: Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Cc: Anand Moon <linux.amoon@gmail.com>,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: add missing ethernet reset ID
Date: Tue, 20 Oct 2020 18:11:12 +0200 [thread overview]
Message-ID: <6fb3199f-f5a6-fa00-94df-9c5a40f394b6@baylibre.com> (raw)
In-Reply-To: <7hft69kl4f.fsf@baylibre.com>
On 20/10/2020 16:49, Kevin Hilman wrote:
> Neil Armstrong <narmstrong@baylibre.com> writes:
>
>> On 20/10/2020 14:01, Jerome Brunet wrote:
>>> From: Anand Moon <linux.amoon@gmail.com>
>>>
>>> Add reset external reset of the ethernet mac controller
>>>
>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>
> [...]
>
>> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Neil, do we need this in u-boot also? I seem to have network issues in
> u-boot on board with external PHY running mainline u-boot.
Yes, U-boot supports it, but simply does "reset_deassert", so I don't think
it would have any impact, the real issue is the PHY reset.
Without a proper reset line, no idea how to do that cleanly.
Neil
>
> Kevin
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-10-20 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 12:01 Jerome Brunet
2020-10-20 13:12 ` Neil Armstrong
2020-10-20 14:49 ` Kevin Hilman
2020-10-20 16:11 ` Neil Armstrong [this message]
2020-10-20 19:46 ` Martin Blumenstingl
2020-10-20 23:14 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb3199f-f5a6-fa00-94df-9c5a40f394b6@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.amoon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®