From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A845CC6B1A for ; Wed, 14 Oct 2026 08:28:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KjLeehLAO7UBkQmLKRuHZwY2iAzv357YgVhIPHDw6r4=; b=KuLiatPjAZ+Q8e/Vo5/zhJU9BN 57mla6MMfO7o1iBye0yMo1gBplyoeHqC0yK7rIm8iZeX0OvlVmkKvpVR2cWi8k7wD9jTCw1QC6m6V 69rkmcdRh0LB8si5QrhC968/mZXphvoLHmuCNVqdRpJhBn9lnuqgUXUtfzsxipDtKgsa82/VuPsCq IUIsJBMzBYr4yS5rQANIX+QrNDaUYP7+HPfGqJ2t4ubrFPok2HtQV6Of49Ai2dOLSg1tmo0KU5BAC 68UqZtip8WxtJ3QcqDdS0hwTEa1sCQO6nzEnDdIxJxu6RVzxQDFAhTYEhT8qgpEmTrZtdxSYsjvah XmInLz4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGuLX-0000000Et2G-3Z5m; Wed, 14 Oct 2026 08:28:23 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGuLU-0000000Et0w-3Yw2 for linux-amlogic@bombadil.infradead.org; Wed, 14 Oct 2026 08:28:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:References:Cc:To:Subject:Reply-To:From:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description; bh=BEWX0NnWZSM0xUTF33KaixK1TLeuUgRnotvYl3b7sMI=; b=TfP9p6FNi7hJOxVECyOdZWV3Wz jB1/swSOtBdCOa6kMt2AmVvENMUmrZTmy9Tq2r2r8nFcykqVkeB0v+BWKrifWay7jUfdBr7m0t8Ot Rvig9gwadV7V8IWc/BispBjy2MsZ7cuWDVGX1xLO+2DenmDUYLC7i5WJLoSgWf67gTQwZBaKgPksE u1BhgYnMZS4NAeHvULOqL2jBh0xUAbNUPlf8mqaw73063TuBQbJP5wuDhCO4j8cnuzNkPLmcTYYz5 9M9tegMgyspC9JAx/sqzNYWYLaWa3w35Ddo51ltWBSw0PnShb+agxNcevYj8W2Ty9isjgyDHQ7AOq eL9i3Tdg==; Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by desiato.infradead.org with esmtps (Exim 4.99.5 #2 (Red Hat Linux)) id 1xGuLQ-0000000GV6K-45H1 for linux-amlogic@lists.infradead.org; Wed, 14 Oct 2026 08:28:19 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4a19cba5c14so31748615e9.3 for ; Wed, 14 Oct 2026 01:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1791966495; x=1792571295; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BEWX0NnWZSM0xUTF33KaixK1TLeuUgRnotvYl3b7sMI=; b=b2X0KHkzqfZaohVGsMxUROCTHRmR5sQWw6dgF1oYs7FyLTeEMPGn9GS64o/2JTmhcY F+r3aS9jrtlhpA/YttJM35u8HfSAsYpj0JdeSo84f6LSO4ePXIVCo9K92bhBZmVlMkGs y1AyoDQ/uXOLdzRj5QMme2IGgs6UO94CjTM6ta8fe4UBARYoqx/3jxvRZCFtehgUW/wh eSuAyRn2zU/BvqY824MONZu8TeHj0B9mPOjhMQ95CRfkDL/LS9B4HP7Qk1HXAe/ohsVO K3Ef8aKbi8Bq8EvnnM3Ub6gOdegybguwKgwVOKA95gxR2xIEXfrApXwruVLknK71BPbk dLOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791966495; x=1792571295; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=BEWX0NnWZSM0xUTF33KaixK1TLeuUgRnotvYl3b7sMI=; b=clC6jz4Poi/qT0bmr0GhueiqODQ4smUPWjAgDZpYbKlfFVia3c1QlvPQD8+2aV2FfD 793CLU5+3PAisCgcIfwRA/rFSaur2wYC6gAp5fKtyBLivfNTSI+V8N86n3gZQ/fVLc51 VA94OvraMr6XZHFUl5RZeQ1r4C8N6LkJ5kOck3nhfHkvKqnctWd2EYUVjV3o3mhJyiiE k19NcJncZ6e8aXYUjsTXkbxdbkr2oC7aVqGZ3DFqKJ3MYmlaFtgFO8lXLAtdDogwD+fA fZOSO3K8M6SL4vama8LIdCkI4ZMdIQwRUtV89fPhDYkIG4Rg3AzmT+HxgXt8tbXDIkfA aXEg== X-Forwarded-Encrypted: i=1; AKwUvBwQozUFrIGuiKV4yeRRcIYN7Y0uPUJitHTAA3rW5CLzrYskFqxbatr9zsVfr0nN5E/QQrX/ciap5Yi7cUr/@lists.infradead.org X-Gm-Message-State: AFq9FYI9EutUMNDIBc8VUqOYQQiIsQBA1Kg6mh4WTAuZmF6qo0tAmoWG Yd++d3JYJOYtW3kROe24hHUtLLz1XwRCR2fXmwGBXn6bZbdI8IrR0aBxfmHv2YPWpQw= X-Gm-Gg: AYBFou1shfNhsO3Rmcf4nbnS3Au0mFnddECarBBj4P4rWYV9QVwCaW2FE8ufdO1xj9E nN3qcaqUm2hSxv/MB/bUESq+9xRgiBYeTINZbYTwhlZ2JC0FNTcygbMEULPDS3XOUyYFlsw23nL Gh6763TfXnd7SARGimtAoDiL31ZQyADzEH+L5dvusejMDSdgrXMB+8n61pMSX/CuQQDsVQNLwnO 3pyfWUmNjYIDGZOf0o7toiuArjPx/Kv2sPhwgHtlsoSWHmlBlAijxFY39NNkH16YxPIjXMijrvS 6ErpFCByB07OtbJjrHdOfzjHHuiT4uJpRNeBZjWTBcET268+LiEm+ULHK7AukqWY8aETG09YYIg x/oREq8KKSNvICxeiz2Kwojb+XpWpV5QI26sCYiNUbH6/g1TmUdYC39mALPRbBBf6ahXzWTJf4M TiXNbaio9OVWP4ezpPyCBR6pQfWVNIhiI30yy9LXa8ly4hvIAf5cHTESAmedPvk+VTky0uKka1h rE9xHus0d6hSxQjS4FhuLW/DNR4vyaZB7j7flKuXz+g76Y/nE9gI50= X-Received: by 2002:a05:600c:8b04:b0:4a0:1e37:ae41 with SMTP id 5b1f17b1804b1-4a18e4d67edmr291581105e9.24.1791966494135; Wed, 14 Oct 2026 01:28:14 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:ef1f:5ab3:36fa:3ccb? ([2a01:e0a:106d:1080:ef1f:5ab3:36fa:3ccb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1b4b8a184sm17182865e9.2.2026.10.14.01.28.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 01:28:13 -0700 (PDT) Message-ID: <7020a7a6-332e-4fd0-a659-d82eb768614c@linaro.org> Date: Wed, 14 Oct 2026 10:28:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 2/2] dt-bindings: usb: snps,dwc3: Fix downstream port numbering To: Chen-Yu Tsai , Greg Kroah-Hartman , Felipe Balbi , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Sven Peter , Janne Grunau , Neal Gompa , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Michal Simek , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peter Griffin , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Tudor Ambarus , Heiko Stuebner , Alim Akhtar , Kunihiko Hayashi , Masami Hiramatsu , Yixun Lan , Troy Mitchell , Minda Chen , Shyam Pandey , Wei Yang , Senchuan Zhang , Hang Cao , Li Jun , Peng Fan , Roy Luo , Yang Xiwen , Ahmad Zainie , Robert Marko , Xu Yang , Wesley Cheng , Stanley Chang , Ze Huang , Aswath Govindraju , Roger Quadros , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, imx@lists.linux.dev, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev References: <20261014082037.1774672-1-wenst@chromium.org> <20261014082037.1774672-3-wenst@chromium.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20261014082037.1774672-3-wenst@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261014_092817_274780_E9CE105A X-CRM114-Status: GOOD ( 23.91 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 10/14/26 10:20, Chen-Yu Tsai wrote: > The DWC3 controller can operate in host mode. It does so with a XHCI > compliant host controller. The XHCI has two downstream ports, one for > HS and one for SS. USB downstream ports start from 1, not 0. Is there something in index 0 we will need to define at some point ? Using 0 as base for numbering in DT isn't incompatible with the USB spec using base 1 for numbering, > > Reconcile the downstream port numbering with the common USB host > binding, renumbering the downstream port numbers from 0 and 1 to > 1 and 2. > > This is non-backwards compatible, however it won't break current > major implementations: > > - dwc3 "gadget mode" in Linux kernel only requires a connection to be > present; it doesn't matter which port it is > - dwc3 "host mode" OF graph connections aren't supported yet [1] > - FreeBSD doesn't use the OF graph for anything > - U-boot doesn't use the OF graph for USB > - OpenBSD doesn't support dwc3, only the XHCI in dwc3, and doesn't use > the OF graph for USB > - coreboot doesn't use the OF graph for anything > - Zephyr doesn't support dwc3 > - TF-A doesn't use the OF graph for anything > - EDK2 doesn't support dwc3 and doesn't support OF graph > - OP-TEE doesn't support dwc3 and doesn't support OF graph > > [1] WIP to tie OF graph port node to USB port device > > Fixes: a33113f73693 ("dt-bindings: usb: snps,dwc3: document HS & SS OF graph ports") > Signed-off-by: Chen-Yu Tsai > --- > It is unclear to me whether the HS/SS numbering is fixed for all dwc3 > variants. I checked Allwinner H616 and Rockchip RK3588 and they both > have HS as port 1 and SS as port 2. > > This also doesn't cover a potential "multi-port" DWC3 implementation, > which Qualcomm seems to have. It breaks the current Qualcomm numbering on numerous boards. > --- > Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml > index 6c0b8b653824..4b6304bd2ec1 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml > @@ -410,11 +410,11 @@ properties: > property is used. > > properties: > - port@0: > + port@1: > $ref: /schemas/graph.yaml#/properties/port > description: High Speed (HS) data bus. > > - port@1: > + port@2: > $ref: /schemas/graph.yaml#/properties/port > description: Super Speed (SS) data bus. > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic