From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16106C4321E for ; Mon, 5 Dec 2022 08:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nBXAjTE+RXjbjUJIgXs8QE87JGoDELcEFq1ZD7F3clo=; b=zPvmTy5EnIRVny 2TvtjF3cbr/STe+7bcHWUjmCk/l1hO28aJvcYXMRhpmu3fD8czfMJ358AIobOcqPnYGACbZ/N/kuI VzH73w4TXPDwQQcidZjtxxcLF4xZTYl3NHM4yT5ypLM7BPXRJ1EengRuSVhhQYx4LLYEpb3g0buyI OoX4E0JICUD6tja7aFWahgw6ojsd77d3iARlK15FI6syZ+cx1O18O6pQlmXhXuJR6yNKPBFmu2qqf fSAQ/leS2psBJgAXSm3nd5ugim2h879mMRCjU1lYGgP75/fNmnMeDq5sfX929JfmzqJRitjH/q+X3 cLxJ91KUu1RKy92hIyIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p26Xg-00FzVc-Hf; Mon, 05 Dec 2022 08:09:36 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p26Xc-00FzTo-Ra; Mon, 05 Dec 2022 08:09:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 18BA360FA1; Mon, 5 Dec 2022 08:09:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C7DDC433D6; Mon, 5 Dec 2022 08:09:26 +0000 (UTC) Message-ID: <71443a0d-9ca2-c3a0-8ac1-1fb98e4e74b3@xs4all.nl> Date: Mon, 5 Dec 2022 09:09:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 7/9] media: dt-bindings: cec-gpio: convert to DT schema Content-Language: en-US To: Krzysztof Kozlowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Thierry Reding , Jonathan Hunter , Marek Szyprowski , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Joe Tessler , Yannick Fertre , Jeff Chase , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20221204182908.138910-1-krzysztof.kozlowski@linaro.org> <20221204182908.138910-7-krzysztof.kozlowski@linaro.org> From: Hans Verkuil In-Reply-To: <20221204182908.138910-7-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221205_000933_022118_06CC913F X-CRM114-Status: GOOD ( 28.82 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 04/12/2022 19:29, Krzysztof Kozlowski wrote: > Convert HDMI CEC GPIO bindings to DT schema. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Hans Verkuil Thanks! Hans > --- > .../devicetree/bindings/media/cec-gpio.txt | 42 ----------- > .../bindings/media/cec/cec-gpio.yaml | 73 +++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 74 insertions(+), 43 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/cec-gpio.txt > create mode 100644 Documentation/devicetree/bindings/media/cec/cec-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/media/cec-gpio.txt b/Documentation/devicetree/bindings/media/cec-gpio.txt > deleted file mode 100644 > index 47e8d73d32a3..000000000000 > --- a/Documentation/devicetree/bindings/media/cec-gpio.txt > +++ /dev/null > @@ -1,42 +0,0 @@ > -* HDMI CEC GPIO driver > - > -The HDMI CEC GPIO module supports CEC implementations where the CEC line > -is hooked up to a pull-up GPIO line and - optionally - the HPD line is > -hooked up to another GPIO line. > - > -Please note: the maximum voltage for the CEC line is 3.63V, for the HPD and > -5V lines it is 5.3V. So you may need some sort of level conversion circuitry > -when connecting them to a GPIO line. > - > -Required properties: > - - compatible: value must be "cec-gpio". > - - cec-gpios: gpio that the CEC line is connected to. The line should be > - tagged as open drain. > - > -If the CEC line is associated with an HDMI receiver/transmitter, then the > -following property is also required: > - > - - hdmi-phandle - phandle to the HDMI controller, see also cec.txt. > - > -If the CEC line is not associated with an HDMI receiver/transmitter, then > -the following property is optional and can be used for debugging HPD changes: > - > - - hpd-gpios: gpio that the HPD line is connected to. > - > -This property is optional and can be used for debugging changes on the 5V line: > - > - - v5-gpios: gpio that the 5V line is connected to. > - > -Example for the Raspberry Pi 3 where the CEC line is connected to > -pin 26 aka BCM7 aka CE1 on the GPIO pin header, the HPD line is > -connected to pin 11 aka BCM17 and the 5V line is connected to pin > -15 aka BCM22 (some level shifter is needed for the HPD and 5V lines!): > - > -#include > - > -cec-gpio { > - compatible = "cec-gpio"; > - cec-gpios = <&gpio 7 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > - hpd-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>; > - v5-gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > -}; > diff --git a/Documentation/devicetree/bindings/media/cec/cec-gpio.yaml b/Documentation/devicetree/bindings/media/cec/cec-gpio.yaml > new file mode 100644 > index 000000000000..19169d58316a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/cec/cec-gpio.yaml > @@ -0,0 +1,73 @@ > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/cec/cec-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HDMI CEC GPIO > + > +maintainers: > + - Hans Verkuil > + > +description: | > + The HDMI CEC GPIO module supports CEC implementations where the CEC line is > + hooked up to a pull-up GPIO line and - optionally - the HPD line is hooked up > + to another GPIO line. > + > + Please note:: the maximum voltage for the CEC line is 3.63V, for the HPD and > + 5V lines it is 5.3V. So you may need some sort of level conversion > + circuitry when connecting them to a GPIO line. > + > +properties: > + compatible: > + const: cec-gpio > + > + cec-gpios: > + maxItems: 1 > + description: > + GPIO that the CEC line is connected to. The line should be tagged as open > + drain. > + > + hpd-gpios: > + maxItems: 1 > + description: > + GPIO that the HPD line is connected to. Used for debugging HPD changes > + when the CEC line is not associated with an HDMI receiver/transmitter. > + > + v5-gpios: > + maxItems: 1 > + description: > + GPIO that the 5V line is connected to. Used for debugging changes on the > + 5V line. > + > +required: > + - compatible > + - cec-gpios > + > +allOf: > + - $ref: cec-common.yaml# > + - if: > + required: > + - hdmi-phandle > + then: > + properties: > + hpd-gpios: false > + > + - if: > + required: > + - hpd-gpios > + then: > + properties: > + hdmi-phandle: false > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + > + cec { > + compatible = "cec-gpio"; > + cec-gpios = <&gpio 7 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > + hpd-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>; > + v5-gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 05acbaecef52..197351d3bb57 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4848,7 +4848,7 @@ L: linux-media@vger.kernel.org > S: Supported > W: http://linuxtv.org > T: git git://linuxtv.org/media_tree.git > -F: Documentation/devicetree/bindings/media/cec-gpio.txt > +F: Documentation/devicetree/bindings/media/cec/cec-gpio.yaml > F: drivers/media/cec/platform/cec-gpio/ > > CELL BROADBAND ENGINE ARCHITECTURE _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic