From: yixun.lan@amlogic.com (Yixun Lan)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v5 2/7] clk: meson: aoclk: refactor common code into dedicated file
Date: Tue, 17 Apr 2018 16:16:39 +0800 [thread overview]
Message-ID: <759078f5-fcbf-9ef1-6945-67d9d951d8eb@amlogic.com> (raw)
In-Reply-To: <1523875084.2601.28.camel@baylibre.com>
Hi Jerome
On 04/16/18 18:38, Jerome Brunet wrote:
>> + */
>> + for (clkid = 0; clkid < data->num_clks; clkid++) {
>> + data->clks[clkid]->map = regmap;
>> +
>> + ret = devm_clk_hw_register(dev, data->hw_data->hws[clkid]);
>> + if (ret)
>> + return ret;
>> + }
>> +
>> + return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
>> + (void *) data->hw_data);
>> +}
> Missing new line here. Please run checkpatch and pay attention to git warnings
> about whitespace errors.
>
I think we actually need to avoid this extra new line, or what's the
benefits with new line?
and besides? I didn't see any complaint from checkpatch.pl ..
./scripts/checkpatch.pl
0002-clk-meson-aoclk-refactor-common-code-into-dedicated-.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#235:
new file mode 100644
total: 0 errors, 1 warnings, 302 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or
--fix-inplace.
0002-clk-meson-aoclk-refactor-common-code-into-dedicated-.patch has
style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Yixun
next prev parent reply other threads:[~2018-04-17 8:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 14:37 [PATCH v5 0/7] clk: meson-axg: Add AO Cloclk and Reset driver Yixun Lan
2018-04-09 14:37 ` [PATCH v5 1/7] clk: meson: migrate to devm_of_clk_add_hw_provider API Yixun Lan
2018-04-09 14:37 ` [PATCH v5 2/7] clk: meson: aoclk: refactor common code into dedicated file Yixun Lan
2018-04-16 10:38 ` Jerome Brunet
2018-04-17 8:16 ` Yixun Lan [this message]
2018-04-17 14:15 ` Jerome Brunet
2018-04-16 11:34 ` Jerome Brunet
2018-04-17 8:17 ` Yixun Lan
2018-04-09 14:37 ` [PATCH v5 3/7] dt-bindings: clock: axg-aoclkc: New binding for Meson-AXG SoC Yixun Lan
2018-04-09 14:37 ` [PATCH v5 4/7] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings Yixun Lan
2018-04-16 9:59 ` Jerome Brunet
2018-04-16 10:09 ` Philipp Zabel
2018-04-09 14:37 ` [PATCH v5 5/7] clk: meson-axg: Add AO Clock and Reset controller driver Yixun Lan
2018-04-16 11:45 ` Jerome Brunet
2018-04-17 8:18 ` Yixun Lan
2018-04-09 14:37 ` [PATCH v5 6/7] clk: meson: drop CLK_SET_RATE_PARENT flag Yixun Lan
2018-04-09 14:37 ` [PATCH v5 7/7] clk: meson: drop CLK_IGNORE_UNUSED flag Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=759078f5-fcbf-9ef1-6945-67d9d951d8eb@amlogic.com \
--to=yixun.lan@amlogic.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®