From: Joe Perches <joe@perches.com>
To: Ondrej Jirman <megous@megous.com>, linux-kernel@vger.kernel.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
"open list:ARM/Amlogic Meson SoC support"
<linux-amlogic@lists.infradead.org>,
"moderated list:ARM/Amlogic Meson SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] phy: phy-meson-g12a-usb2: Fix GENMASK misuse
Date: Sat, 22 Feb 2020 18:15:12 -0800 [thread overview]
Message-ID: <7792266dfede1df5742e527dc304b610fcfbd025.camel@perches.com> (raw)
In-Reply-To: <20200222235142.242732-1-megous@megous.com>
On Sun, 2020-02-23 at 00:51 +0100, Ondrej Jirman wrote:
> Arguments to GENMASK should be msb >= lsb.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
> I just grepped the whole kernel tree for GENMASK argument order issues,
> and this is one of the three that popped up. No testing was done.
Both of these were submitted last year.
https://lkml.org/lkml/2019/7/10/20
I hope they get applied one day.
Neither patch has an affect today as none of the
#defines are used.
Perhaps deleting the #defines is better.
> drivers/phy/amlogic/phy-meson-g12a-usb2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> index 9065ffc85eb47..cd7eccab26490 100644
> --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> @@ -66,7 +66,7 @@
> #define PHY_CTRL_R14 0x38
> #define PHY_CTRL_R14_I_RDP_EN BIT(0)
> #define PHY_CTRL_R14_I_RPU_SW1_EN BIT(1)
> - #define PHY_CTRL_R14_I_RPU_SW2_EN GENMASK(2, 3)
> + #define PHY_CTRL_R14_I_RPU_SW2_EN GENMASK(3, 2)
> #define PHY_CTRL_R14_PG_RSTN BIT(4)
> #define PHY_CTRL_R14_I_C2L_DATA_16_8 BIT(5)
> #define PHY_CTRL_R14_I_C2L_ASSERT_SINGLE_EN_ZERO BIT(6)
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-02-23 2:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 23:51 Ondrej Jirman
2020-02-23 2:15 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7792266dfede1df5742e527dc304b610fcfbd025.camel@perches.com \
--to=joe@perches.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=megous@megous.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®