From: Valerio Setti <vsetti@baylibre.com>
To: sashiko-reviews@lists.linux.dev
Cc: neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 2/2] ASoC: meson: aiu-formatter: remove pipeline reset from prepare
Date: Thu, 2 Jul 2026 22:44:51 +0200 [thread overview]
Message-ID: <787586e0-f11a-48ec-8a07-8e56043b7da8@baylibre.com> (raw)
In-Reply-To: <20260702111422.42BA01F000E9@smtp.kernel.org>
On 7/2/26 1:14 PM, sashiko-bot@kernel.org wrote:
>> diff --git a/sound/soc/meson/aiu-formatter-i2s.c b/sound/soc/meson/aiu-formatter-i2s.c
>> index b4604734fe88d..cb554c2e7ce4a 100644
>> --- a/sound/soc/meson/aiu-formatter-i2s.c
>> +++ b/sound/soc/meson/aiu-formatter-i2s.c
> [ ... ]
>> @@ -55,11 +54,11 @@ static int aiu_formatter_i2s_prepare(struct regmap *map,
>> {
>> /* Always operate in split (classic interleaved) mode */
>> unsigned int desc = 0;
>> - unsigned int tmp;
>>
>> - /* Reset required to update the pipeline */
>> - regmap_write(map, AIU_RST_SOFT, AIU_RST_SOFT_I2S_FAST);
>> - regmap_read(map, AIU_I2S_SYNC, &tmp);
>> + /*
>> + * Pipeline reset is already implemented in aiu_fifo_i2s_trigger() at
>> + * trigger time.
>> + */
>
> [Severity: High]
> Does removing this reset break dynamic DAPM routing (DPCM)?
>
> When a backend is dynamically connected to an already-running frontend via
> DPCM, the frontend's trigger() callback is not invoked again.
>
> For example, if the I2S FIFO frontend is started (e.g., routed to the SPDIF
> backend) and then the I2S backend is dynamically connected while the stream is
> running, the "I2S Formatter" DAPM widget powers up and calls
> aiu_formatter_i2s_prepare().
>
> Without the reset pulse here, will the hardware fail to latch new
> configurations (like AIU_I2S_SOURCE_DESC), potentially resulting in corrupted
> or no audio output from the I2S backend?
>
I'm not sure about this. The reason I removed the pipeline reset was
that having it happening after the one on the FIFO side caused the
stream at 24-bits to be corrupted.
In the scenario described by Sashiko we would have had the pipeline
reset again after the one from the FIFO (which is continuouly running).
Moreover I think that this would have happened also before my series
that was recently merged, i.e. c7852d2dcf66
("ASoC: meson: aiu: align I2S design to the AXG one"), so I have some
doubt that this could have worked seamlessly also before recent changes.
--
Valerio
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-07-02 20:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 10:56 [PATCH 0/2] ASoC: meson: aiu: fix playback issue for 24-bit mode Valerio Setti
2026-07-02 10:56 ` [PATCH 1/2] ASoC: meson: gx-formatter: prepare on attach Valerio Setti
2026-07-02 11:10 ` sashiko-bot
2026-07-02 20:34 ` Valerio Setti
2026-07-03 7:34 ` Jerome Brunet
2026-07-02 10:56 ` [PATCH 2/2] ASoC: meson: aiu-formatter: remove pipeline reset from prepare Valerio Setti
2026-07-02 11:14 ` sashiko-bot
2026-07-02 20:44 ` Valerio Setti [this message]
2026-07-03 7:58 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=787586e0-f11a-48ec-8a07-8e56043b7da8@baylibre.com \
--to=vsetti@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®