From: arvind.yadav.cs@gmail.com (Arvind Yadav)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/6 v2] mmc: s3cmci: Fix platform_get_irq's error checking
Date: Sat, 18 Nov 2017 15:03:44 +0530 [thread overview]
Message-ID: <7952b7c2d5bb853ac6b09517e634b1838d9729a2.1510997223.git.arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com>
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
drivers/mmc/host/s3cmci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index f7f157a..cc801bc 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -1658,9 +1658,9 @@ static int s3cmci_probe(struct platform_device *pdev)
}
host->irq = platform_get_irq(pdev, 0);
- if (host->irq == 0) {
+ if (host->irq <= 0) {
dev_err(&pdev->dev, "failed to get interrupt resource.\n");
- ret = -EINVAL;
+ ret = host->irq;
goto probe_iounmap;
}
--
2.7.4
next prev parent reply other threads:[~2017-11-18 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 9:33 [PATCH 1/6 v2] mmc: meson-gx-mmc: " Arvind Yadav
2017-11-18 9:33 ` Arvind Yadav [this message]
2017-11-18 9:33 ` [PATCH 3/6 v2] mmc: sdhci-acpi: Handle return value of platform_get_irq Arvind Yadav
2017-11-18 9:33 ` [PATCH 4/6 v2] mmc: sdhci-spear: " Arvind Yadav
2017-11-20 5:44 ` Viresh Kumar
2017-11-20 6:45 ` Arvind Yadav
2017-11-18 9:33 ` [PATCH 5/6 v2] mmc: sh_mmcif: " Arvind Yadav
2017-11-18 9:33 ` [PATCH 6/6 v2] mmc: sunxi-mmc: " Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7952b7c2d5bb853ac6b09517e634b1838d9729a2.1510997223.git.arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®