From: yixun.lan@amlogic.com (Yixun Lan)
To: linus-amlogic@lists.infradead.org
Subject: dt-bindings: Invalid SPDX License Identifier
Date: Mon, 23 Apr 2018 15:21:22 +0800 [thread overview]
Message-ID: <795a50ff-d627-bcd5-950f-71e98016707e@amlogic.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1804222108120.6136@nanos.tec.linutronix.de>
Hi Thomas
On 04/23/18 03:14, Thomas Gleixner wrote:
> Yixun,
>
> commit c16292578ffa437c77e17d5d3da20330a10b8a86
> Author: Yixun Lan <yixun.lan@amlogic.com>
> Date: Fri Nov 10 16:46:49 2017 +0800
>
> dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller
>
> Add DT bindings for the Meson-AXG SoC Reset Controller include file,
> and also slightly update documentation.
>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> Added the following SPDX-License-Identifier: (GPL-2.0+ OR BSD) in the
> middle of the top of file comment.
>
> There are two problems with that:
>
> 1) BSD is not a valid SPDX identifier. See https://spdx.org/licenses/
>
> You need to say which BSD variant you mean.
>
> 2) Please put the License identifier to the place which is defined in
> Documentation/process/licenses.rst, i.e. the first line of the dts file
> and not to some random place.
>
thanks for pointing this out
I will adjust the license to "GPL-2.0+ OR BSD-3-Clause" since this file
was copied from include/dt-bindings/reset/amlogic,meson-gxbb-reset.h
and it's a good idea to preserve the old license.
Yixun
parent reply other threads:[~2018-04-23 7:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.DEB.2.21.1804222108120.6136@nanos.tec.linutronix.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=795a50ff-d627-bcd5-950f-71e98016707e@amlogic.com \
--to=yixun.lan@amlogic.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®