From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19283FA3728 for ; Thu, 17 Oct 2019 01:27:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC77B2082C for ; Thu, 17 Oct 2019 01:27:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S9kOZu8F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC77B2082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RSdh5mEuZYcnD0KDalXEfqjZBRac5eVjk8eto9+f9HA=; b=S9kOZu8FeeZYT1 Dd+a4rpDddNIt6bLky/SvFa1hEHEtlBHChUWUTyvkE0NX7BNjK0qAwmv0j7haSNyqd2PnpnZC1tst XMqD1EbloUmlnSkIxQhl/pfb0xpjD6N45vunny+T70OF/JM2a2Ub/V4F3yPXvR2FmSmt6m0bPpDcL d2fdQz20BrcbKw8p7qL3Rc1I4Dbt4LOc3rTQAQAkNx8JCjrDlet82A90vzA1ATvCZXCrvpLTjwiON 3NM62kcE3vw8nPL/E6MuMMkBT+sGd3gMr3crkYGqWNr4mSznPsxEtvbMS5HPSUDDGTTb6206c3xiF AIamM77zLqIQhcnrLyEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKuZb-0005QU-8N; Thu, 17 Oct 2019 01:27:27 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKuZX-0005PO-Sj; Thu, 17 Oct 2019 01:27:25 +0000 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 735A76153B773426C5B9; Thu, 17 Oct 2019 09:27:20 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Thu, 17 Oct 2019 09:27:17 +0800 Subject: Re: [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code To: Florian Fainelli , , , , , , , , , , , , , , , , , , References: <20191016104621.26056-1-yuehaibing@huawei.com> <2c60b926-1e98-cca0-ec17-6b45f9da404a@gmail.com> From: Yuehaibing Message-ID: <7c0269b6-cab3-bded-7f9d-76430be89f9c@huawei.com> Date: Thu, 17 Oct 2019 09:27:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <2c60b926-1e98-cca0-ec17-6b45f9da404a@gmail.com> X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_182724_095062_DDBB7608 X-CRM114-Status: UNSURE ( 9.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 2019/10/17 0:44, Florian Fainelli wrote: > On 10/16/19 3:46 AM, YueHaibing wrote: >> devm_platform_ioremap_resource() internally have platform_get_resource() >> and devm_ioremap_resource() in it. So instead of calling them separately >> use devm_platform_ioremap_resource() directly. > > Did your coccinelle script not cover > drivers/char/hw_random/iproc-rng200.c somehow? Do you mind including it > as a separate patch? A patch from Markus Elfring has be queued: commit a68b931932c5574aa5bd459529c766ba577c72b3 Author: Markus Elfring Date: Wed Sep 18 09:09:22 2019 +0200 hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe() Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Reviewed-by: Ray Jui Reviewed-by: Florian Fainelli Signed-off-by: Herbert Xu > Thanks > >> >> YueHaibing (13): >> hwrng: atmel - use devm_platform_ioremap_resource() to simplify code >> hwrng: bcm2835 - use devm_platform_ioremap_resource() to simplify code >> hwrng: exynos - use devm_platform_ioremap_resource() to simplify code >> hwrng: hisi - use devm_platform_ioremap_resource() to simplify code >> hwrng: ks-sa - use devm_platform_ioremap_resource() to simplify code >> hwrng: meson - use devm_platform_ioremap_resource() to simplify code >> hwrng: npcm - use devm_platform_ioremap_resource() to simplify code >> hwrng: omap - use devm_platform_ioremap_resource() to simplify code >> hwrng: pasemi - use devm_platform_ioremap_resource() to simplify code >> hwrng: pic32 - use devm_platform_ioremap_resource() to simplify code >> hwrng: st - use devm_platform_ioremap_resource() to simplify code >> hwrng: tx4939 - use devm_platform_ioremap_resource() to simplify code >> hwrng: xgene - use devm_platform_ioremap_resource() to simplify code >> >> drivers/char/hw_random/atmel-rng.c | 4 +--- >> drivers/char/hw_random/bcm2835-rng.c | 5 +---- >> drivers/char/hw_random/exynos-trng.c | 4 +--- >> drivers/char/hw_random/hisi-rng.c | 4 +--- >> drivers/char/hw_random/ks-sa-rng.c | 4 +--- >> drivers/char/hw_random/meson-rng.c | 4 +--- >> drivers/char/hw_random/npcm-rng.c | 4 +--- >> drivers/char/hw_random/omap-rng.c | 4 +--- >> drivers/char/hw_random/pasemi-rng.c | 4 +--- >> drivers/char/hw_random/pic32-rng.c | 4 +--- >> drivers/char/hw_random/st-rng.c | 4 +--- >> drivers/char/hw_random/tx4939-rng.c | 4 +--- >> drivers/char/hw_random/xgene-rng.c | 4 +--- >> 13 files changed, 13 insertions(+), 40 deletions(-) >> > > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic